From: Bjorn Helgaas <helgaas@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Philipp Stanner <pstanner@redhat.com>,
Hans de Goede <hdegoede@redhat.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Bjorn Helgaas <bhelgaas@google.com>,
Sam Ravnborg <sam@ravnborg.org>,
dakr@redhat.com, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v7 10/13] PCI: Give pci(m)_intx its own devres callback
Date: Thu, 13 Jun 2024 13:47:10 -0500 [thread overview]
Message-ID: <20240613184710.GA1072582@bhelgaas> (raw)
In-Reply-To: <6cd568a9-1332-5a47-bdb2-ea079a8462af@linux.intel.com>
On Thu, Jun 13, 2024 at 08:23:26PM +0300, Ilpo Järvinen wrote:
> On Wed, 5 Jun 2024, Philipp Stanner wrote:
>
> > pci_intx() is one of the functions that have "hybrid mode" (i.e.,
> > sometimes managed, sometimes not). Providing a separate pcim_intx()
> > function with its own device resource and cleanup callback allows for
> > removing further large parts of the legacy PCI devres implementation.
> > +/* Used to restore the old intx state on driver detach. */
>
> INTx
Updated locally in v9 series.
> > @@ -392,32 +397,75 @@ int pcim_set_mwi(struct pci_dev *pdev)
> > }
> > EXPORT_SYMBOL(pcim_set_mwi);
> >
> > +
> > static inline bool mask_contains_bar(int mask, int bar)
>
> Stray change.
Updated locally in v9 series.
next prev parent reply other threads:[~2024-06-13 18:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 8:15 [PATCH v7 00/13] Make PCI's devres API more consistent Philipp Stanner
2024-06-05 8:15 ` [PATCH v7 01/13] PCI: Add and use devres helper for bit masks Philipp Stanner
2024-06-13 16:57 ` Ilpo Järvinen
2024-06-05 8:15 ` [PATCH v7 02/13] PCI: Add devres helpers for iomap table Philipp Stanner
2024-06-05 8:15 ` [PATCH v7 03/13] PCI: Reimplement plural devres functions Philipp Stanner
2024-06-13 16:54 ` Ilpo Järvinen
2024-06-13 18:45 ` Bjorn Helgaas
2024-06-05 8:15 ` [PATCH v7 04/13] PCI: Deprecate two surplus " Philipp Stanner
2024-06-05 8:15 ` [PATCH v7 05/13] PCI: Make devres region requests consistent Philipp Stanner
2024-06-05 8:15 ` [PATCH v7 06/13] PCI: Warn users about complicated devres nature Philipp Stanner
2024-06-05 8:15 ` [PATCH v7 07/13] PCI: Move dev-enabled status bit to struct pci_dev Philipp Stanner
2024-06-05 21:11 ` Bjorn Helgaas
2024-06-06 7:59 ` Philipp Stanner
2024-06-05 8:16 ` [PATCH v7 08/13] PCI: Move pinned " Philipp Stanner
2024-06-05 8:16 ` [PATCH v7 09/13] PCI: Give pcim_set_mwi() its own devres callback Philipp Stanner
2024-06-13 17:19 ` Ilpo Järvinen
2024-06-14 8:15 ` Philipp Stanner
2024-06-05 8:16 ` [PATCH v7 10/13] PCI: Give pci(m)_intx " Philipp Stanner
2024-06-13 17:23 ` Ilpo Järvinen
2024-06-13 18:47 ` Bjorn Helgaas [this message]
2024-06-05 8:16 ` [PATCH v7 11/13] PCI: Remove legacy pcim_release() Philipp Stanner
2024-06-05 8:16 ` [PATCH v7 12/13] PCI: Add pcim_iomap_range() Philipp Stanner
2024-06-05 8:16 ` [PATCH v7 13/13] drm/vboxvideo: fix mapping leaks Philipp Stanner
2024-06-07 19:40 ` [PATCH v7 00/13] Make PCI's devres API more consistent Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240613184710.GA1072582@bhelgaas \
--to=helgaas@kernel.org \
--cc=airlied@gmail.com \
--cc=bhelgaas@google.com \
--cc=dakr@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=pstanner@redhat.com \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox