From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: linux-pci@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Dan Williams <dan.j.williams@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lukas Wunner <lukas@wunner.de>, Keith Busch <kbusch@kernel.org>,
Marek Behun <marek.behun@nic.cz>, Pavel Machek <pavel@ucw.cz>,
Randy Dunlap <rdunlap@infradead.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Stuart Hayes <stuart.w.hayes@gmail.com>
Subject: Re: [PATCH v2 2/3] PCI/NPEM: Add Native PCIe Enclosure Management support
Date: Fri, 14 Jun 2024 15:40:49 +0200 [thread overview]
Message-ID: <20240614154049.000016ec@linux.intel.com> (raw)
In-Reply-To: <3e4718ce-8371-93e2-b390-cc3b263f31df@linux.intel.com>
On Tue, 28 May 2024 16:55:16 +0300 (EEST)
Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> wrote:
> > +#define PCI_NPEM_IND_SPEC_0 0x00800000
> > +#define PCI_NPEM_IND_SPEC_1 0x01000000
> > +#define PCI_NPEM_IND_SPEC_2 0x02000000
> > +#define PCI_NPEM_IND_SPEC_3 0x04000000
> > +#define PCI_NPEM_IND_SPEC_4 0x08000000
> > +#define PCI_NPEM_IND_SPEC_5 0x10000000
> > +#define PCI_NPEM_IND_SPEC_6 0x20000000
> > +#define PCI_NPEM_IND_SPEC_7 0x40000000
>
> Are these off-by-one, shouldn't that field go all the way to the last bit
> which is 0x80000000 (the field is 31:24)??
Yes, I made a mistake. Good catch!
Mariusz
next prev parent reply other threads:[~2024-06-14 13:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 13:19 [PATCH v2 0/3] PCIe Enclosure LED Management Mariusz Tkaczyk
2024-05-28 13:19 ` [PATCH v2 1/3] leds: Init leds class earlier Mariusz Tkaczyk
2024-05-29 4:22 ` Dan Williams
2024-06-14 14:08 ` Lukas Wunner
2024-06-14 14:13 ` Greg Kroah-Hartman
2024-05-28 13:19 ` [PATCH v2 2/3] PCI/NPEM: Add Native PCIe Enclosure Management support Mariusz Tkaczyk
2024-05-28 13:55 ` Ilpo Järvinen
2024-06-14 13:40 ` Mariusz Tkaczyk [this message]
2024-05-29 5:21 ` Dan Williams
2024-05-29 9:38 ` Lukas Wunner
2024-06-12 11:40 ` Mariusz Tkaczyk
2024-06-13 16:11 ` stuart hayes
2024-06-19 14:28 ` Mariusz Tkaczyk
2024-06-14 21:06 ` stuart hayes
2024-06-15 10:33 ` Lukas Wunner
2024-06-18 8:56 ` Mariusz Tkaczyk
2024-06-18 17:13 ` Lukas Wunner
2024-06-18 18:50 ` stuart hayes
2024-06-18 19:32 ` Dan Williams
2024-06-19 9:08 ` Lukas Wunner
2024-06-19 12:07 ` Mariusz Tkaczyk
2024-05-28 13:19 ` [PATCH v2 3/3] PCI/NPEM: Add _DSM PCIe SSD status LED management Mariusz Tkaczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240614154049.000016ec@linux.intel.com \
--to=mariusz.tkaczyk@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kbusch@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=marek.behun@nic.cz \
--cc=pavel@ucw.cz \
--cc=rdunlap@infradead.org \
--cc=stuart.w.hayes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox