Re: [PATCH v4 3/3] PCI: rockchip: Refactor rockchip_pcie_disable_clocks function signature

Manivannan Sadhasivam
2024-08-15T16:25:06Z

On Tue, Jun 25, 2024 at 04:10:34PM +0530, Anand Moon wrote:
> Updated rockchip_pcie_disable_clocks function to accept
> a struct rockchip pointer instead of a void pointer.
>

Please use imperative tone in all patch descriptions.

s/Updated/Update

> Signed-off-by: Anand Moon <linux.amoon@gmail.com>

With above,

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

- Mani

> ---
> v4: None
> v3: None
> v2: None
> ---
> drivers/pci/controller/pcie-rockchip.c | 4 +---
> drivers/pci/controller/pcie-rockchip.h | 2 +-
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pci/controller/pcie-rockchip.c b/drivers/pci/controller/pcie-rockchip.c
> index 024308bb6ac8..81deb7fc6882 100644
> --- a/drivers/pci/controller/pcie-rockchip.c
> +++ b/drivers/pci/controller/pcie-rockchip.c
> @@ -272,10 +272,8 @@ int rockchip_pcie_enable_clocks(struct rockchip_pcie *rockchip)
> }
> EXPORT_SYMBOL_GPL(rockchip_pcie_enable_clocks);
>
> -void rockchip_pcie_disable_clocks(void *data)
> +void rockchip_pcie_disable_clocks(struct rockchip_pcie *rockchip)
> {
> - struct rockchip_pcie *rockchip = data;
> -
> clk_bulk_disable_unprepare(ROCKCHIP_NUM_CLKS, rockchip->clks);
> }
> EXPORT_SYMBOL_GPL(rockchip_pcie_disable_clocks);
> diff --git a/drivers/pci/controller/pcie-rockchip.h b/drivers/pci/controller/pcie-rockchip.h
> index 27e951b41b80..3330b1e55dcd 100644
> --- a/drivers/pci/controller/pcie-rockchip.h
> +++ b/drivers/pci/controller/pcie-rockchip.h
> @@ -354,7 +354,7 @@ int rockchip_pcie_init_port(struct rockchip_pcie *rockchip);
> int rockchip_pcie_get_phys(struct rockchip_pcie *rockchip);
> void rockchip_pcie_deinit_phys(struct rockchip_pcie *rockchip);
> int rockchip_pcie_enable_clocks(struct rockchip_pcie *rockchip);
> -void rockchip_pcie_disable_clocks(void *data);
> +void rockchip_pcie_disable_clocks(struct rockchip_pcie *rockchip);
> void rockchip_pcie_cfg_configuration_accesses(
> struct rockchip_pcie *rockchip, u32 type);
>
> --
> 2.44.0
>
>

--
மணிவண்ணன் சதாசிவம்