Linux PCI subsystem development
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
To: Niklas Cassel <cassel@kernel.org>
Cc: kernel test robot <lkp@intel.com>,
	oe-kbuild-all@lists.linux.dev, linux-pci@vger.kernel.org,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [pci:controller/rockchip 10/11] drivers/pci/controller/dwc/pcie-designware-ep.c:26:undefined reference to `pci_epc_init_notify'
Date: Fri, 28 Jun 2024 09:12:14 +0900	[thread overview]
Message-ID: <20240628001214.GB2060184@rocinante> (raw)
In-Reply-To: <ZnxmHFkIvm-qTfiD@ryzen.lan>

Hello,

[...]
> > All errors (new ones prefixed by >>):
> > 
> >    loongarch64-linux-ld: drivers/pci/controller/dwc/pcie-designware-ep.o: in function `dw_pcie_ep_init_notify':
> > >> drivers/pci/controller/dwc/pcie-designware-ep.c:26:(.text+0x1e4): undefined reference to `pci_epc_init_notify'
> 
> Seeing that it is pcie-designware-ep.c that fails to build, I can see the error.
> I have forgotten to do:
> 
> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index 9c4fb8ba7573..4c38181acffa 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -329,6 +329,7 @@ config PCIE_ROCKCHIP_DW_EP
>         bool "Rockchip DesignWare PCIe controller (endpoint mode)"
>         depends on ARCH_ROCKCHIP || COMPILE_TEST
>         depends on OF
> +       depends on PCI_ENDPOINT
>         select PCIE_DW_EP
>         select PCIE_ROCKCHIP_DW
>         help
> 
> (The .config in this build has PCIE_ROCKCHIP_DW_EP selected, but not PCI_ENDPOINT,
> which should not be allowed...)
> 
> This is my fault, all the other endpoint drivers have a depends on PCI_ENDPOINT.
> Will send a patch for this shortly. I'm truly sorry for this mistake.

No worries.  Thank you for a quick fix!  Much appreciated.

	Krzysztof

      reply	other threads:[~2024-06-28  0:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-26 18:23 [pci:controller/rockchip 10/11] drivers/pci/controller/dwc/pcie-designware-ep.c:26:undefined reference to `pci_epc_init_notify' kernel test robot
2024-06-26 19:03 ` Niklas Cassel
2024-06-28  0:12   ` Krzysztof Wilczyński [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240628001214.GB2060184@rocinante \
    --to=kwilczynski@kernel.org \
    --cc=cassel@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox