From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F48612DD90 for ; Tue, 9 Jul 2024 05:12:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720501930; cv=none; b=qACP54Qx0hHelaK0h/RZ2b0jmxO+YNFlpuitwHhc1yRmePINYRNscW9WB57Y/l5cTKnuOMjpAW7f4zZN6f72g+ur87vLJlHm0jJi1hvvcK8eZS81mInX+7/pMiLTOBGKJxf1MZuyzyJGAee2q2vCvsyb3OtxJEeJxdaZfBXhIKs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720501930; c=relaxed/simple; bh=hZrNby8Wqv1N1agmOmeRetovV+1eWf/UR5CpaOhm0R8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZsoIMSgQ0HmEMOhf2vuz03s4das7TooUjdOfK6hZatN/Ij/1U04rG2NiZtkT8CVIKVj1zuKQrUqUOWE7sZ2MAO1XqYGsH6p2BcCQcleo1lXsND6tgndVAJGaCC5tO8Tm5hFcPLZNg1YWHSBmL1T8XfzrJksLOk6k+WdJvMWeHVU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xUdWgw4X; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xUdWgw4X" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1fb3b7d0d3aso25432875ad.2 for ; Mon, 08 Jul 2024 22:12:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720501929; x=1721106729; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=5dnB1YYKwyLNgKX3mrii2OWpX3QNNGe1qm9HISwK1nM=; b=xUdWgw4XANdVplxUzfgRvHB5QQfSFwktQUWWkfM0mnWvMTC3ffCAFX7gz3gHgPcIDe 5+lIvNGuTmrJCk83lAL+zmKG/W1bDcX6nOQzVoW9Sq/OgkEQINXpjiSUx1j3y646mE7G BqtBFAGt9UQ4wYYZmxoBzM2p+l70HAJmuZjG58oxPeWcxMVBSU/H8kAgEB/zYvNGzx4o ruiiw+OKz4pmONm7uvBeQfzNdgTheIOzIVYz1ZWxTOUZdt9VYrrqTXXPm5uj6y7jz8Av 8y2En0kyc/U8pESKWo2j4k2yVTGxKgWdkgG+JQVc7cruyTO5HuNrb7u+ZIejTE80YMH2 c5mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720501929; x=1721106729; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5dnB1YYKwyLNgKX3mrii2OWpX3QNNGe1qm9HISwK1nM=; b=P2YGnn4zSHAF1mqIeSJgziKY+agREaDrU3wiAqaeiE+ES9t65W1YILEpc6YuWnHx/G 9RNAMRW6eQAkLn5W0cjzwgV3Z8sKkPZmU7YCbOk0lfbRf2raPwMknTjljz2TzOYejSsJ PGE1UlAszZd9inz0ojlMN6qrOw3CGsFAAC14gqQJqshLRLyHPosW7NsINQ01lg5EDSRc kVl/FmE26oTZMSsAkl23j2RdxGLw4XIseQnSJkwg8YELn0Hb3XMjhhqRq4Ir5Krwk/Lh XOP5FoPMvOBdV1OsfHwneCpg4/pSJE3nuIx9TmPG3Os0f9ZHvRibGSKq842FMOhRrOD1 w2kA== X-Forwarded-Encrypted: i=1; AJvYcCWtx5HXqEo7xcaGFEpVdr63lyrG7mm16YbYxPBUZcxHIXHEU+fGtky9wWHFAm0qC5r2TrDX8XFS2Z5/CCeOGuU5KlO1htPj/zdB X-Gm-Message-State: AOJu0YzkCzEHfQIwWXe6BC/UZmDvn0qpfxDhJd/MOKzfeZI7uY8Y13Nr zkIKyExmVHr5NMV0sP7MtwE1dwY+BviTipgv6CPfaW4FTo8Ua/rK4kCUt/qHtA== X-Google-Smtp-Source: AGHT+IGUuK2UPKdJxtdpUL/3YL7x4TdstpPSjGT5aU1aDddxROeYmfS2zo6ROceQtZz5OxfKCLYnNQ== X-Received: by 2002:a17:902:db03:b0:1fa:abda:cf7b with SMTP id d9443c01a7336-1fbb6cdac2cmr14557545ad.9.1720501928752; Mon, 08 Jul 2024 22:12:08 -0700 (PDT) Received: from thinkpad ([117.193.209.237]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fbb6a2bedbsm7161425ad.101.2024.07.08.22.12.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jul 2024 22:12:08 -0700 (PDT) Date: Tue, 9 Jul 2024 10:41:55 +0530 From: Manivannan Sadhasivam To: Dan Carpenter Cc: Krishna chaitanya chundru , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] PCI: qcom: Fix missing error code in qcom_pcie_probe() Message-ID: <20240709051155.GG3820@thinkpad> References: <20240708180539.1447307-1-dan.carpenter@linaro.org> <20240708180539.1447307-2-dan.carpenter@linaro.org> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240708180539.1447307-2-dan.carpenter@linaro.org> On Mon, Jul 08, 2024 at 01:05:36PM -0500, Dan Carpenter wrote: > Return a negative error code if dev_pm_opp_find_freq_floor() fails. > Don't return success. > > Fixes: 78b5f6f8855e ("PCI: qcom: Add OPP support to scale performance") > Signed-off-by: Dan Carpenter Reviewed-by: Manivannan Sadhasivam - Mani > --- > drivers/pci/controller/dwc/pcie-qcom.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index 26405fcfa499..1d36311f9adb 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -1574,7 +1574,8 @@ static int qcom_pcie_probe(struct platform_device *pdev) > if (!ret) { > opp = dev_pm_opp_find_freq_floor(dev, &max_freq); > if (IS_ERR(opp)) { > - dev_err_probe(pci->dev, PTR_ERR(opp), > + ret = PTR_ERR(opp); > + dev_err_probe(pci->dev, ret, > "Unable to find max freq OPP\n"); > goto err_pm_runtime_put; > } else { > -- > 2.43.0 > -- மணிவண்ணன் சதாசிவம்