From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E121B13A89A for ; Tue, 9 Jul 2024 07:09:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720508965; cv=none; b=Ho2h/UNgWiG4SJ3zsQicMJizhH5vJaz1IgtfmoS6nmBBzYKECCbeTK4vgYMD1BojbyCq3T3C2t4NO3KkSpuYL+EnooPe9shqy38Ez5o2TFrSJWgduJlJmVi3fr9TFxXh1hJd347W2D9wzuojONiXdIrGpGPS8qYgP+fbqqMf9Q8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720508965; c=relaxed/simple; bh=0EbaZGBCGAlDdaBpz5q6jU7//pUs+PQe1Irem1Hb25U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L6eQAd3qijc726H677Eps7TpN/NJZZDGjZ2ltCc6odm0L8ous+Ij++nHP4uSesQ//tfCZoKryuB+5W1CEi18aEC8uFMgdFwd83cSkUnMjfNwjZCUyVcAzatyTHRTC4sUu/1Pw58xanc5lc11rJad+qYOgCBkb/MCItQNK19KTEo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=G3iN3ZOH; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="G3iN3ZOH" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-70b4267ccfcso774123b3a.3 for ; Tue, 09 Jul 2024 00:09:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720508963; x=1721113763; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=ktSm4q1vxdmtkavfLnfXdh6fXORXctBwSCyUPkuRKh8=; b=G3iN3ZOHopm3mtgq9x4VbtBLd7+87pueMbEYcQnnSp50fQkEH9BunryS3idlc32bpT lICEHU3GZHkY6Fwt7b9n/M5TKQFOVUQZvoD74yUU+EpI3lFFb8632YEi03ZfU+Qi5bnJ 4idXjAj9chCnjQ10t+syErNh4P75UXzPKEs+Tz59s2qZo2Ovi/589E5YmZu8JIV+LHKy jzKgFEDncvzG8JmfsCPJJ8u97LtgXRSHL1jyNzPe7YOmQZSklLEXEV/3FUMbBhu+vgi5 2aS5lOpQPue0NMExEIelXgPamT6oLqKd1j2UffxQpiGZKmHarRAwnIy17hJ8C0wWXYgb mLoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720508963; x=1721113763; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ktSm4q1vxdmtkavfLnfXdh6fXORXctBwSCyUPkuRKh8=; b=TcR//Cn6Zw60ytkbsfqOQcxr9hUmphnN9gzS8+SdLGW4pMFEAUjvzwuXhwXlJBR1HQ sQtacW5eC2R2UlS1jKReO2zui6XcQvtDWAONJYKkUOJxjQuqiCYkIeTo4rvUbDJN/hvg IBTnMYAkVF6qd3uGxqmo+94iTriohuHv1vI/dJkqMVm+n5Ecp6UiK/sKfcsY2cRzvEX3 xM/ivwqFkAyYb+zZ6c01vZSBaPKli30VolGq7VtBGgqr0IAxTRhPT5Pkipg9OOrnRAhd xrUBrQmIj7oU0gKs71fp4C+VajiRHCvtHHE3a2eTUs5zb2xwY/UTj/LF8ZA8UI+9OZp+ xSJg== X-Forwarded-Encrypted: i=1; AJvYcCWRiwqhH/MSYVe9dhpQnKOxhh2tJQ4d0EeWXBdeptMQQe+NB2RY+I2sW5T+PyE0pCvgbBk3X6nkKtWTGP0xPndnxFYyTTcoxnAT X-Gm-Message-State: AOJu0YwG4tW76XVA/6tze5m+OcXeeIdtmPyyDWsYsAt86I55eizqMjry a5UTuAbl0XiZWcrSkvXM4SRwb3SRa9cTUoPcYf3cXlriWsPTygzdHSUoNY2ugw== X-Google-Smtp-Source: AGHT+IFqpYgrrt5uc3kzJJ3RWffhZnZTxn37z39ek238VkDPJg7zYx6wk2uXBCCVizNNoOnNVTUF1w== X-Received: by 2002:a05:6a00:2352:b0:70b:1525:9adf with SMTP id d2e1a72fcca58-70b4364fe15mr2135383b3a.22.1720508963273; Tue, 09 Jul 2024 00:09:23 -0700 (PDT) Received: from thinkpad ([120.60.141.33]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70b438c27b0sm1064532b3a.64.2024.07.09.00.09.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jul 2024 00:09:22 -0700 (PDT) Date: Tue, 9 Jul 2024 12:39:15 +0530 From: Manivannan Sadhasivam To: Varadarajan Narayanan Cc: lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, quic_krichai@quicinc.com, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] pci: qcom: Fix 'opp' variable usage Message-ID: <20240709070915.GA7865@thinkpad> References: <20240709063620.4125951-1-quic_varada@quicinc.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240709063620.4125951-1-quic_varada@quicinc.com> On Tue, Jul 09, 2024 at 12:06:20PM +0530, Varadarajan Narayanan wrote: > qcom_pcie_icc_opp_update() calls 'dev_pm_opp_put(opp)' regardless > of the success of dev_pm_opp_find_freq_exact(). > > If dev_pm_opp_find_freq_exact() had failed and 'opp' had some > error value, the subsequent dev_pm_opp_put(opp) results in a > crash. Hence call dev_pm_opp_put(opp) only if 'opp' has a valid > value. > > Fixes: 78b5f6f8855e ("PCI: qcom: Add OPP support to scale performance") > Signed-off-by: Varadarajan Narayanan Fix was already submitted: https://lore.kernel.org/linux-pci/20240708180539.1447307-3-dan.carpenter@linaro.org/ - Mani > --- > drivers/pci/controller/dwc/pcie-qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index 26405fcfa499..2a80d4499c25 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -1443,8 +1443,8 @@ static void qcom_pcie_icc_opp_update(struct qcom_pcie *pcie) > if (ret) > dev_err(pci->dev, "Failed to set OPP for freq (%lu): %d\n", > freq_kbps * width, ret); > + dev_pm_opp_put(opp); > } > - dev_pm_opp_put(opp); > } > } > > -- > 2.34.1 > -- மணிவண்ணன் சதாசிவம்