From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: [PATCH] PCI/pwrctl: reduce the amount of Kconfig noise
Date: Tue, 16 Jul 2024 17:23:18 +0200 [thread overview]
Message-ID: <20240716152318.207178-1-brgl@bgdev.pl> (raw)
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Kconfig will ask the user twice about power sequencing: once for the QCom
WCN power sequencing driver and then again for the PCI power control
driver using it.
Let's remove the public menuconfig entry for PCI pwrctl and instead
default the relevant symbol to 'm' only for the architectures that
actually need it.
Fixes: 4565d2652a37 ("PCI/pwrctl: Add PCI power control core code")
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Closes: https://lore.kernel.org/lkml/CAHk-=wjWc5dzcj2O1tEgNHY1rnQW63JwtuZi_vAZPqy6wqpoUQ@mail.gmail.com/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
drivers/pci/pwrctl/Kconfig | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/pci/pwrctl/Kconfig b/drivers/pci/pwrctl/Kconfig
index f1b824955d4b..b8f289e6a185 100644
--- a/drivers/pci/pwrctl/Kconfig
+++ b/drivers/pci/pwrctl/Kconfig
@@ -1,17 +1,10 @@
# SPDX-License-Identifier: GPL-2.0-only
-menu "PCI Power control drivers"
-
config PCI_PWRCTL
tristate
config PCI_PWRCTL_PWRSEQ
- tristate "PCI Power Control driver using the Power Sequencing subsystem"
+ tristate
select POWER_SEQUENCING
select PCI_PWRCTL
default m if ((ATH11K_PCI || ATH12K) && ARCH_QCOM)
- help
- Enable support for the PCI power control driver for device
- drivers using the Power Sequencing subsystem.
-
-endmenu
--
2.43.0
next reply other threads:[~2024-07-16 15:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-16 15:23 Bartosz Golaszewski [this message]
2024-07-16 15:59 ` [PATCH] PCI/pwrctl: reduce the amount of Kconfig noise Manivannan Sadhasivam
2024-07-16 16:29 ` Bartosz Golaszewski
2024-07-16 16:33 ` Manivannan Sadhasivam
2024-07-16 17:38 ` Bartosz Golaszewski
2024-07-16 18:08 ` Linus Torvalds
2024-07-16 18:48 ` Bartosz Golaszewski
2024-07-16 19:02 ` Linus Torvalds
2024-07-16 20:10 ` Bartosz Golaszewski
2024-07-16 20:29 ` Linus Torvalds
2024-07-17 12:31 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240716152318.207178-1-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=bartosz.golaszewski@linaro.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).