From: Bjorn Helgaas <helgaas@kernel.org>
To: ngn <ngn@ngn.tf>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] PCI: shpchp: Remove hpc_ops
Date: Mon, 22 Jul 2024 14:58:08 -0500 [thread overview]
Message-ID: <20240722195808.GA729979@bhelgaas> (raw)
In-Reply-To: <Zp48oG47T_ZcwSI1@archbtw>
On Mon, Jul 22, 2024 at 02:04:00PM +0300, ngn wrote:
> hpc_ops struct is only used by shpchp, and it's unnecessary. This is
> explained in the TODO file: drivers/pci/hotplug/TODO.
This is a true statement, but it doesn't actually say what the patch
*does* about it.
The subject line does say it, but it should also be in the commit log
itself because the subject is a title, not part of the commit log:
https://chris.beams.io/posts/git-commit/
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v6.9#n94
Point to the commit(s) that make similar changes to other drivers.
Please also update the TODO file to remove this item.
> Signed-off-by: ngn <ngn@ngn.tf>
> ---
What's the change from v1? It can go here (below the "---" cut line),
where it's useful but doesn't get included in the commit log when
merged.
Bjorn
prev parent reply other threads:[~2024-07-22 19:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 11:04 [PATCH v2] PCI: shpchp: Remove hpc_ops ngn
2024-07-22 19:58 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240722195808.GA729979@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=ngn@ngn.tf \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).