Re: [PATCH v2 1/2] dt-bindings: PCI: xilinx-xdma: Add schemas for Xilinx QDMA PCIe Root Port Bridge

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2927 bytes --]

On Wed, Jul 24, 2024 at 09:30:21AM +0000, Havalige, Thippeswamy wrote:
> Hi Conor Dooley,
> 
> > -----Original Message-----
> > From: Conor Dooley <conor@kernel.org>
> > Sent: Monday, July 22, 2024 10:15 PM
> > To: Havalige, Thippeswamy <thippeswamy.havalige@amd.com>
> > Cc: lpieralisi@kernel.org; kw@linux.com; robh@kernel.org;
> > bhelgaas@google.com; krzk+dt@kernel.org; conor+dt@kernel.org; linux-
> > kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-
> > pci@vger.kernel.org; Havalige, Thippeswamy
> > <thippeswamy.havalige@amd.com>; linux-arm-kernel@lists.infradead.org;
> > Simek, Michal <michal.simek@amd.com>
> > Subject: Re: [PATCH v2 1/2] dt-bindings: PCI: xilinx-xdma: Add schemas for
> > Xilinx QDMA PCIe Root Port Bridge
> > 
> > On Mon, Jul 22, 2024 at 11:55:57AM +0530, Thippeswamy Havalige wrote:
> > > Add YAML devicetree schemas for Xilinx QDMA Soft IP PCIe Root Port
> > Bridge.
> > >
> > > Signed-off-by: Thippeswamy Havalige <thippesw@amd.com>
> > > ---
> > >  .../bindings/pci/xlnx,xdma-host.yaml          | 41 ++++++++++++++++++-
> > >  1 file changed, 39 insertions(+), 2 deletions(-)
> > > ---
> > > changes in v2
> > > - update dt node label with pcie.
> > > ---
> > > diff --git a/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml
> > b/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml
> > > index 2f59b3a73dd2..28d9350a7fb4 100644
> > > --- a/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml
> > > +++ b/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml
> > > @@ -14,10 +14,21 @@ allOf:
> > >
> > >  properties:
> > >    compatible:
> > > -    const: xlnx,xdma-host-3.00
> > > +    enum:
> > > +      - xlnx,xdma-host-3.00
> > > +      - xlnx,qdma-host-3.00
> > >
> > >    reg:
> > > -    maxItems: 1
> > > +    items:
> > > +      - description: configuration region and XDMA bridge register.
> > > +      - description: QDMA bridge register.
> > 
> > Please constrain the new entry to only the new compatible.
> - Thanks, I ll resend patch with required changes.

Weird quoting btw, the - isn't needed.

> > > +    minItems: 1
> > > +
> > > +  reg-names:
> > > +    items:
> > > +      - const: cfg
> > > +      - const: breg
> > > +    minItems: 1
> > >
> > >    ranges:
> > >      maxItems: 2
> > > @@ -111,4 +122,30 @@ examples:
> > >                  interrupt-controller;
> > >              };
> > >          };
> > > +
> > > +        pcie@80000000 {
> > 
> > tbh, don't see the point of a new example for this.
> - For this in both examples ranges properties are different. So, here I wanted to make sure that our example device tree bindings work straight forward when our reference designs are used.

Different ranges properties doesn't justify a new example. They don't
exist to be copy-pasted, but rather to demonstrate usage of properties
and validate the binding.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]