From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04F4913E020 for ; Wed, 24 Jul 2024 13:50:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721829036; cv=none; b=BlZvy76JqqV529yQXJUVca5DKJ46xloIbPNY9d9FgMkmioJJc8WBPNtaCJokpfc+D6i2tmzPqQk4+kWXidQz7fn2bzXNfO7u2qJOH2kWvT4Jpx3B5cf8mXK9Bz8t5dF+y5t3+3YW0xInS9w517fszkROvIDzWwf/iqtof9YSAIA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721829036; c=relaxed/simple; bh=s18bgWf0OFUxHbMJYtCB40QxzEeOIwnX88xESSf+9Fg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Dv0SQUkqhikOipOR1+aUkwShkCJJbpxQv3r0a6FykYNagB1ygbO55Q9LFI7ke5dxnlRa0lu27Xxej8oZKEKQbEBd71aKkhwH57ZtTjM3eM9iuOYO7AolKcMYpAP1moVNVAghle2dM+Sc4RIbSCqtw4yvd0AhpzErkHjbqqiHGK0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=v3Yjsp1F; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="v3Yjsp1F" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-70d333d57cdso1990249b3a.3 for ; Wed, 24 Jul 2024 06:50:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721829032; x=1722433832; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=pbALP3QIjCL6mWz14PmpKACkxPrqfTSuSK7rkKg3La4=; b=v3Yjsp1FfWuzXR9KIvO1sxZkyZ4mOVGYGKyozb7kadyq1MoPFScmzH2QQHJYZe9WaM RD8KbmLLPq46jJSZhRkvJ09YODH1i4JmFjhNQZymiCsbjiRnmRZf/Rt37Idx2rmNUBHO h+bCoQGAAqbzsKs8yr6LiIhkXqQV6GPMJKj08dr4ZGNSLoQiDSbWbMTIckSTzjxZvHTv n6FBvJPMbvtDmMnihdG3uHF5APlKQeqYtOPiHXQMydY+9HecBLgebR1Jenm5ygvbvC7P YtRnphDYSMYHx4BYzPpt2XasfJY4+VvYDtr3Kmp/4/P6v4puN46UdB8YG9ohZi7wbNrZ GcyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721829032; x=1722433832; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pbALP3QIjCL6mWz14PmpKACkxPrqfTSuSK7rkKg3La4=; b=feZQkOIhgGdDrOFxmFiBVtJohw0AAXYYE1PI76lqmlPysRN8BTsJrXFgZXsBYP8LLz tIeZgqpkUypEyQTYR/LxNxOMEa0FXHtGlinBsOMMJC2l3QFDjitBCcDRZD3+f2ovLUSN +ZdxUaxDD5B0GjVaJhoUR+k+mrhuzAtJZ1r9LzXiZlqZPq1Fn/YTiB2DNAVGcOsZ8IX2 0Wtj5qmGPU/rhDP0UU3b+4REWFXpCtc8JbD2Y1iaE/C7lifQilgKzZHDmAcBIebcyHZG RiS+WfEVCw+XwKo51hA7uTHB33kivEHmB+hTRSynSCSuckKXgp9Row0IyOxWr4Eq3NPt wOew== X-Gm-Message-State: AOJu0YyOo/I2Ck60UhiWyigHwPKuVFxqTyIgJVcEtIQaYL4strMDF+Bj nhi4Uy+NyMocp1i9U6qc5fL9m9jh5JiygGKkEYoLKXKkVZu9Z7RlkT9pjfqEOA== X-Google-Smtp-Source: AGHT+IG0YFoIL4lPnBLT+Aopu2jQ/kCeCrRtyAOg5jS+eqaqVK57qCofzoxxbC6rl3vwtZMbLKsHKg== X-Received: by 2002:a05:6a00:a82:b0:70d:3337:7820 with SMTP id d2e1a72fcca58-70e99689086mr3278241b3a.8.1721829032049; Wed, 24 Jul 2024 06:50:32 -0700 (PDT) Received: from thinkpad ([103.244.168.26]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70d22f50f46sm5507795b3a.77.2024.07.24.06.50.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jul 2024 06:50:31 -0700 (PDT) Date: Wed, 24 Jul 2024 19:20:20 +0530 From: Manivannan Sadhasivam To: Marek Vasut Cc: linux-pci@vger.kernel.org, Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Pali =?iso-8859-1?Q?Roh=E1r?= , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Aleksandr Mishin , Anna-Maria Behnsen , Anup Patel , Bjorn Helgaas , Broadcom internal kernel review list , Daire McNamara , Damien Le Moal , Florian Fainelli , Hou Zhiqiang , Jianjun Wang , Jim Quinlan , Jingoo Han , Jisheng Zhang , Jon Hunter , Jonathan Derrick , Joyce Ooi , Karthikeyan Mitran , Kishon Vijay Abraham I , Koichiro Den , Lorenzo Pieralisi , Marc Zyngier , Michal Simek , Nicolas Saenz Julienne , Niklas Cassel , Nipun Gupta , Nirmal Patel , Rob Herring , Ryder Lee , Shivamurthy Shastri , Siddharth Vadapalli , Thierry Reding , Thomas Gleixner , Thomas Petazzoni , Yoshihiro Shimoda , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v4 00/15] genirq/msi: Silence set affinity failed warning Message-ID: <20240724135020.GD3349@thinkpad> References: <20240723132958.41320-1-marek.vasut+renesas@mailbox.org> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240723132958.41320-1-marek.vasut+renesas@mailbox.org> On Tue, Jul 23, 2024 at 03:27:00PM +0200, Marek Vasut wrote: > Various PCIe controllers that mux MSIs onto single IRQ line produce these > "IRQ%d: set affinity failed" warnings when entering suspend. Remove the > .irq_set_affinity callbacks and make sure they are NULL in all affected > controllers, so this warning in kernel/irq/msi.c is not triggered. > > This has been compile-tested only on all but the R-Car PCI controller. > > The clean ups are done per-driver so they can be easily reverted in case > they break something. > Whole series looks good to me (PCI controller specific patches). FWIW, Reviewed-by: Manivannan Sadhasivam - Mani > Marek Vasut (15): > genirq/msi: Silence set affinity failed warning > PCI: aardvark: Silence set affinity failed warning > PCI: altera-msi: Silence set affinity failed warning > PCI: brcmstb: Silence set affinity failed warning > PCI: dwc: Silence set affinity failed warning > PCI: mediatek-gen3: Silence set affinity failed warning > PCI: mediatek: Silence set affinity failed warning > PCI: mobiveil: Silence set affinity failed warning > PCI: plda: Silence set affinity failed warning > PCI: rcar-host: Silence set affinity failed warning > PCI: tegra: Silence set affinity failed warning > PCI: vmd: Silence set affinity failed warning > PCI: xilinx-nwl: Silence set affinity failed warning > PCI: xilinx-xdma: Silence set affinity failed warning > PCI: xilinx: Silence set affinity failed warning > > drivers/pci/controller/dwc/pci-keystone.c | 7 ------- > drivers/pci/controller/dwc/pcie-designware-host.c | 12 +++--------- > .../pci/controller/mobiveil/pcie-mobiveil-host.c | 11 ++--------- > drivers/pci/controller/pci-aardvark.c | 10 ++-------- > drivers/pci/controller/pci-tegra.c | 10 ++-------- > drivers/pci/controller/pcie-altera-msi.c | 11 ++--------- > drivers/pci/controller/pcie-brcmstb.c | 11 ++--------- > drivers/pci/controller/pcie-mediatek-gen3.c | 13 +++---------- > drivers/pci/controller/pcie-mediatek.c | 11 ++--------- > drivers/pci/controller/pcie-rcar-host.c | 10 ++-------- > drivers/pci/controller/pcie-xilinx-dma-pl.c | 11 ++--------- > drivers/pci/controller/pcie-xilinx-nwl.c | 11 ++--------- > drivers/pci/controller/pcie-xilinx.c | 9 ++------- > drivers/pci/controller/plda/pcie-plda-host.c | 11 ++--------- > drivers/pci/controller/vmd.c | 13 +------------ > include/linux/msi.h | 2 ++ > kernel/irq/msi.c | 2 +- > 17 files changed, 32 insertions(+), 133 deletions(-) > > Cc: "Krzysztof Wilczyński" > Cc: "Pali Rohár" > Cc: "Uwe Kleine-König" > Cc: Aleksandr Mishin > Cc: Anna-Maria Behnsen > Cc: Anup Patel > Cc: Bjorn Helgaas > Cc: Broadcom internal kernel review list > Cc: Daire McNamara > Cc: Damien Le Moal > Cc: Florian Fainelli > Cc: Hou Zhiqiang > Cc: Jianjun Wang > Cc: Jim Quinlan > Cc: Jingoo Han > Cc: Jisheng Zhang > Cc: Jon Hunter > Cc: Jonathan Derrick > Cc: Jonathan Hunter > Cc: Joyce Ooi > Cc: Karthikeyan Mitran > Cc: Kishon Vijay Abraham I > Cc: Koichiro Den > Cc: Lorenzo Pieralisi > Cc: Manivannan Sadhasivam > Cc: Marc Zyngier > Cc: Michal Simek > Cc: Nicolas Saenz Julienne > Cc: Niklas Cassel > Cc: Nipun Gupta > Cc: Nirmal Patel > Cc: Rob Herring > Cc: Ryder Lee > Cc: Shivamurthy Shastri > Cc: Siddharth Vadapalli > Cc: Thierry Reding > Cc: Thomas Gleixner > Cc: Thomas Petazzoni > Cc: Yoshihiro Shimoda > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-pci@vger.kernel.org > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-rpi-kernel@lists.infradead.org > Cc: linux-tegra@vger.kernel.org > > -- > 2.43.0 > -- மணிவண்ணன் சதாசிவம்