From: Philipp Stanner <pstanner@redhat.com>
To: "Jonathan Corbet" <corbet@lwn.net>,
"Damien Le Moal" <dlemoal@kernel.org>,
"Niklas Cassel" <cassel@kernel.org>,
"Giovanni Cabiddu" <giovanni.cabiddu@intel.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
"Boris Brezillon" <bbrezillon@kernel.org>,
"Arnaud Ebalard" <arno@natisbad.org>,
"Srujana Challa" <schalla@marvell.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Miri Korenblit" <miriam.rachel.korenblit@intel.com>,
"Kalle Valo" <kvalo@kernel.org>,
"Serge Semin" <fancer.lancer@gmail.com>,
"Jon Mason" <jdmason@kudzu.us>,
"Dave Jiang" <dave.jiang@intel.com>,
"Allen Hubbe" <allenbh@gmail.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Kevin Cernekee" <cernekee@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Mark Brown" <broonie@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Philipp Stanner" <pstanner@redhat.com>,
"Jie Wang" <jie.wang@intel.com>,
"Adam Guerin" <adam.guerin@intel.com>,
"Shashank Gupta" <shashank.gupta@intel.com>,
"Damian Muszynski" <damian.muszynski@intel.com>,
"Nithin Dabilpuram" <ndabilpuram@marvell.com>,
"Bharat Bhushan" <bbhushan2@marvell.com>,
"Johannes Berg" <johannes.berg@intel.com>,
"Gregory Greenman" <gregory.greenman@intel.com>,
"Emmanuel Grumbach" <emmanuel.grumbach@intel.com>,
"Yedidya Benshimol" <yedidya.ben.shimol@intel.com>,
"Breno Leitao" <leitao@debian.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"John Ogness" <john.ogness@linutronix.de>,
"Thomas Gleixner" <tglx@linutronix.de>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org, qat-linux@intel.com,
linux-crypto@vger.kernel.org, linux-wireless@vger.kernel.org,
ntb@lists.linux.dev, linux-pci@vger.kernel.org,
linux-serial@vger.kernel.org, linux-sound@vger.kernel.org
Subject: [PATCH 02/10] ata: ahci: Replace deprecated PCI functions
Date: Thu, 1 Aug 2024 19:46:00 +0200 [thread overview]
Message-ID: <20240801174608.50592-3-pstanner@redhat.com> (raw)
In-Reply-To: <20240801174608.50592-1-pstanner@redhat.com>
pcim_iomap_regions_request_all() and pcim_iomap_table() have been
deprecated by the PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate
pcim_iomap_table(), pcim_iomap_regions_request_all()").
Replace these functions with their successors, pcim_iomap() and
pcim_request_all_regions()
Signed-off-by: Philipp Stanner <pstanner@redhat.com>
---
drivers/ata/acard-ahci.c | 6 ++++--
drivers/ata/ahci.c | 6 ++++--
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/ata/acard-ahci.c b/drivers/ata/acard-ahci.c
index 547f56341705..3999305b5356 100644
--- a/drivers/ata/acard-ahci.c
+++ b/drivers/ata/acard-ahci.c
@@ -370,7 +370,7 @@ static int acard_ahci_init_one(struct pci_dev *pdev, const struct pci_device_id
/* AHCI controllers often implement SFF compatible interface.
* Grab all PCI BARs just in case.
*/
- rc = pcim_iomap_regions_request_all(pdev, 1 << AHCI_PCI_BAR, DRV_NAME);
+ rc = pcim_request_all_regions(pdev, DRV_NAME);
if (rc == -EBUSY)
pcim_pin_device(pdev);
if (rc)
@@ -386,7 +386,9 @@ static int acard_ahci_init_one(struct pci_dev *pdev, const struct pci_device_id
if (!(hpriv->flags & AHCI_HFLAG_NO_MSI))
pci_enable_msi(pdev);
- hpriv->mmio = pcim_iomap_table(pdev)[AHCI_PCI_BAR];
+ hpriv->mmio = pcim_iomap(pdev, AHCI_PCI_BAR, 0);
+ if (!hpriv->mmio)
+ return -ENOMEM;
/* save initial config */
ahci_save_initial_config(&pdev->dev, hpriv);
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index a05c17249448..905af6b68d80 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1869,7 +1869,7 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
/* AHCI controllers often implement SFF compatible interface.
* Grab all PCI BARs just in case.
*/
- rc = pcim_iomap_regions_request_all(pdev, 1 << ahci_pci_bar, DRV_NAME);
+ rc = pcim_request_all_regions(pdev, DRV_NAME);
if (rc == -EBUSY)
pcim_pin_device(pdev);
if (rc)
@@ -1893,7 +1893,9 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
if (ahci_sb600_enable_64bit(pdev))
hpriv->flags &= ~AHCI_HFLAG_32BIT_ONLY;
- hpriv->mmio = pcim_iomap_table(pdev)[ahci_pci_bar];
+ hpriv->mmio = pcim_iomap(pdev, ahci_pci_bar, 0);
+ if (!hpriv->mmio)
+ return -ENOMEM;
/* detect remapped nvme devices */
ahci_remap_check(pdev, ahci_pci_bar, hpriv);
--
2.45.2
next prev parent reply other threads:[~2024-08-01 17:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 17:45 [PATCH 00/10] Remove pcim_iomap_regions_request_all() Philipp Stanner
2024-08-01 17:45 ` [PATCH 01/10] PCI: Make pcim_request_all_regions() a public function Philipp Stanner
2024-08-02 0:42 ` Damien Le Moal
2024-08-01 17:46 ` Philipp Stanner [this message]
2024-08-02 0:43 ` [PATCH 02/10] ata: ahci: Replace deprecated PCI functions Damien Le Moal
2024-08-01 17:46 ` [PATCH 03/10] crypto: qat - replace " Philipp Stanner
2024-08-01 17:46 ` [PATCH 04/10] crypto: marvell " Philipp Stanner
2024-08-02 7:29 ` Philipp Stanner
2024-08-01 17:46 ` [PATCH 05/10] intel_th: pci: Replace " Philipp Stanner
2024-08-01 17:46 ` [PATCH 06/10] wifi: iwlwifi: replace " Philipp Stanner
2024-08-01 17:46 ` [PATCH 07/10] ntb: idt: Replace " Philipp Stanner
2024-08-01 17:56 ` Serge Semin
2024-08-01 17:46 ` [PATCH 08/10] serial: rp2: Remove " Philipp Stanner
2024-08-02 5:18 ` Jiri Slaby
2024-08-02 7:39 ` Philipp Stanner
2024-08-01 17:46 ` [PATCH 09/10] ALSA: korg1212: Replace " Philipp Stanner
2024-08-02 8:02 ` Takashi Iwai
2024-08-01 17:46 ` [PATCH 10/10] PCI: Remove pcim_iomap_regions_request_all() Philipp Stanner
2024-08-02 0:44 ` Damien Le Moal
-- strict thread matches above, loose matches on Subject: below --
2024-10-25 14:59 [PATCH 00/10] " Philipp Stanner
2024-10-25 14:59 ` [PATCH 02/10] ata: ahci: Replace deprecated PCI functions Philipp Stanner
2024-10-25 15:55 ` Ilpo Järvinen
2024-10-25 16:22 ` Philipp Stanner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240801174608.50592-3-pstanner@redhat.com \
--to=pstanner@redhat.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=adam.guerin@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=allenbh@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arno@natisbad.org \
--cc=bbhushan2@marvell.com \
--cc=bbrezillon@kernel.org \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=cassel@kernel.org \
--cc=cernekee@gmail.com \
--cc=corbet@lwn.net \
--cc=damian.muszynski@intel.com \
--cc=dave.jiang@intel.com \
--cc=davem@davemloft.net \
--cc=dlechner@baylibre.com \
--cc=dlemoal@kernel.org \
--cc=emmanuel.grumbach@intel.com \
--cc=fancer.lancer@gmail.com \
--cc=giovanni.cabiddu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.greenman@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jdmason@kudzu.us \
--cc=jie.wang@intel.com \
--cc=jirislaby@kernel.org \
--cc=johannes.berg@intel.com \
--cc=john.ogness@linutronix.de \
--cc=kvalo@kernel.org \
--cc=leitao@debian.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=ndabilpuram@marvell.com \
--cc=ntb@lists.linux.dev \
--cc=perex@perex.cz \
--cc=qat-linux@intel.com \
--cc=schalla@marvell.com \
--cc=shashank.gupta@intel.com \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yedidya.ben.shimol@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).