From: "Krzysztof Wilczyński" <kw@linux.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: lpieralisi@kernel.org, robh@kernel.org, bhelgaas@google.com,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: qcom-ep: Do not enable resources during probe()
Date: Wed, 14 Aug 2024 05:25:47 +0900 [thread overview]
Message-ID: <20240813202547.GC1922056@rocinante> (raw)
In-Reply-To: <20240727090604.24646-1-manivannan.sadhasivam@linaro.org>
Hello,
> Starting from commit 869bc5253406 ("PCI: dwc: ep: Fix DBI access failure
> for drivers requiring refclk from host"), all the hardware register access
> (like DBI) were moved to dw_pcie_ep_init_registers() which gets called only
> in qcom_pcie_perst_deassert() i.e., only after the endpoint received refclk
> from host.
>
> So there is no need to enable the endpoint resources (like clk, regulators,
> PHY) during probe(). Hence, remove the call to qcom_pcie_enable_resources()
> helper from probe(). This was added earlier because dw_pcie_ep_init() was
> doing DBI access, which is not done now.
>
> While at it, let's also call dw_pcie_ep_deinit() in err path to deinit the
> EP controller in the case of failure.
Applied to controller/qcom, thank you!
[1/1] PCI: qcom-ep: Do not enable resources during probe()
https://git.kernel.org/pci/pci/c/cd0b3e13ec30
Krzysztof
next prev parent reply other threads:[~2024-08-13 20:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-27 9:06 [PATCH] PCI: qcom-ep: Do not enable resources during probe() Manivannan Sadhasivam
2024-07-27 10:32 ` Dmitry Baryshkov
2024-08-13 17:02 ` Manivannan Sadhasivam
2024-08-13 20:27 ` Krzysztof Wilczyński
2024-08-13 20:25 ` Krzysztof Wilczyński [this message]
2024-08-21 22:56 ` Bjorn Helgaas
2024-08-22 6:48 ` Manivannan Sadhasivam
2024-08-22 15:16 ` Bjorn Helgaas
2024-08-22 15:40 ` Manivannan Sadhasivam
2024-08-22 17:31 ` Bjorn Helgaas
2024-08-23 4:41 ` Manivannan Sadhasivam
2024-08-23 22:04 ` Bjorn Helgaas
2024-08-24 2:19 ` Manivannan Sadhasivam
2024-08-24 16:12 ` Bjorn Helgaas
2024-08-24 16:34 ` Manivannan Sadhasivam
2024-09-01 16:34 ` Krzysztof Wilczyński
2024-08-15 18:15 ` Bjorn Helgaas
2024-08-16 5:37 ` Manivannan Sadhasivam
2024-08-16 12:02 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240813202547.GC1922056@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox