From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA0CE146A6D for ; Thu, 15 Aug 2024 05:57:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723701461; cv=none; b=OwDWmWzFDrUdY95cXudFhpYSy8kgiuYJ+MD76KCMV/tfzpBHUFfzBJOjA32PfNv/Pthx+f5JAuuMuVPbsiYw+Gg4mdPh4jxzYYru6yDdeNMrH0Uu0nhAiHkyDkijhaSncmbJAUBPzDl89qVvHtJKwvcjavfv+qv6yXOP7AuHv04= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723701461; c=relaxed/simple; bh=mXZeQr2Vr+9zCthY+fysuNbATVG4BXJathKzP9Zd7Z8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=mSBkHz5m2BO0tRG8AwS8JXYuh14dSXveVbXgdH4qQIjkBGcJ3QZ2njXsXiR3U3zAT02q4w8RvM6xb5OvAWfPqp9gPnrVrlx7XqY6XyqziPFQqwwkPIvW04ye9v14oOSA9b1r0fumXLTlhRP1UBQ2dBgu7LD2SksYuFG/NOqgtbI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=SKMzwMfT; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="SKMzwMfT" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-201f2b7fe0dso1689915ad.1 for ; Wed, 14 Aug 2024 22:57:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1723701459; x=1724306259; darn=vger.kernel.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=EP1p3+2gvbnxYrGCFl4PMjke3zRORbnj8Xo4kAg7C0E=; b=SKMzwMfTSRXvAUUz28wtvt+H3KNiGicyr/QOmZVxfcyLhfLbGuuGlaVHhXKKMlQUON VHpouH0uCl2XC7EksKpdTqPCepbFaw9W2jOwIEmpBzESRrD0sEwiTYoGOAMLOIrYgQ1n HVlZisW68Xn+8T9bpoWtzYw/GkrqOwBdp0t/Uh+Xi+GhO4g2NxZKBttCGJEaHyQrJ3tO t9D7JLDfuHxWmj4O7CU3BxF+zAjljfAzdREt36Qw2DagT025HlcvyRnQ2mmsNTpp8qjg t1akNTWGkxsblixsIhECMx5cs1L8WAXHV25p/IR+aqZlxoVBdY7d/x2zt4pYNmuisHdS 45qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723701459; x=1724306259; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EP1p3+2gvbnxYrGCFl4PMjke3zRORbnj8Xo4kAg7C0E=; b=MYgtkKfaEdAd4vPINhjeZRU3akJ03Ia3W6qlMvknVy+zw0jz+g8czzMQ1r4r132RnZ JOAcIARevQjqNlJ128PDsp4euj94hsN334Fpi0TWRguJvnA402zdLUAc81BlCkGFHsQ8 jmJwYcSI/v4l5Y7MrS+ETB8QfbvZkV9Ger7o8Bto7/4S2Jzrp4G8krPI0Kk5Mxf7HehZ VF1cmMRQpQcn+eB+OzzLJxSPosutjWUkguCpRC0X3dcm3y1nrY6YiH/LYTsWDCSzo+MY nJfFwmLyn4ohmndUlK2jffJGxv5P0/beLx4lmGBT2LrMDLY5opMpq13vk9BDHb0rp0Hi cSiw== X-Forwarded-Encrypted: i=1; AJvYcCVwgHSJbqFSnIjSUBAx+Z6wPnIzZLbnZMuSNouArUmgby/oE6a/OGMaXEfOrmjkiPex3ef0lr7v3m1RjRDI75iU0MafIq6ZTBdb X-Gm-Message-State: AOJu0YzypYlKE47ar/q5FbAo1NIfWPWfu5YpMz5Btp5eE6iRI5M8Sn06 eUjS9Z+HM+d+ogPEVydaHHUAUQe0DE/B4adKdwe2QN3BCkV1bA4hPcFD3/PZkK0= X-Google-Smtp-Source: AGHT+IHy998p3ercTXCMwdNoj95acF7XreRaGMhWKLw6A40uieiN+1tbJNN5OB1UrtU/Ge5cDx60pA== X-Received: by 2002:a17:903:244e:b0:1fb:4701:be6a with SMTP id d9443c01a7336-201d63b40a2mr61068905ad.20.1723701458884; Wed, 14 Aug 2024 22:57:38 -0700 (PDT) Received: from dev-mattc2.dev.purestorage.com ([208.88.159.128]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-201f031bc36sm4875625ad.100.2024.08.14.22.57.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Aug 2024 22:57:38 -0700 (PDT) From: Matthew W Carlis To: macro@orcam.me.uk Cc: bhelgaas@google.com, ilpo.jarvinen@linux.intel.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, mattc@purestorage.com, mika.westerberg@linux.intel.com, oohall@gmail.com Subject: Re: [PATCH v2 2/4] PCI: Revert to the original speed after PCIe failed link retraining Date: Wed, 14 Aug 2024 23:57:32 -0600 Message-Id: <20240815055732.25252-1-mattc@purestorage.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Sorry past few days have been struggling to buy some time to look at these. Every time I go into the store and ask for more time they try to give me phone cards. Its an improvement to restore the "capable" link speed & in this case I think we're also enabling a user to have over-ridden it if they were to write the register by hand. Its nice to give every potentially "new" device a chance at achieving its full potential. A little outside of the scope of this patch, but I was wondering if the logline should be a warn level logline? I don't honestly know what a "normal" level is for the pci system. Also, instead of saying "retraining ... at 2.5GT/s\n", would it be more clear if it said "forcing downstream link to 2.5GT/s". In my mind its more clear that an action has been taken which produces a potentially less than unexpected speed. I can test this patch on a couple of systems, but I need a week or so to get it done... Reviewed-by: Matthew Carlis