From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C90CF63C for ; Thu, 15 Aug 2024 14:18:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723731524; cv=none; b=kovhTQy+0RpRLNolDL9JefYsZ08yVSzigOwbAldze1Lp6+X2C3SG8pCMDFaB645hMVIiIQAwUJqI3KPzkR6dha9quE3nMfwkmTNm+UxOS/js72BBAp4oyZUBSRQZM6xT2Gr0UHvRE38ngX6PDi2pCnuqeEFWA5aK9UoYj791+RM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723731524; c=relaxed/simple; bh=aRLx/FLTaZV+eCfwzn+UtbvAeAJBzP/aLDAoTy66kLg=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AosrTPNR1S1tv5gw4kHRhCiYyoji3oLbwyMlCxJpT/L9aXj3pTxdtiguqDN4eKYVT5C9HiFfaI5035bvXs3fQaY9wl1z0ZrP6kmp/vS4te38nzIQ/Lr7H/m1NZzjhQIXq/48KyFIplLd0SfOPSeF3zNkTlHosQRrwguz66PLDTs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Wl6by2C5bz6K99h; Thu, 15 Aug 2024 22:15:58 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 7D7D6140A9C; Thu, 15 Aug 2024 22:18:39 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 15 Aug 2024 15:18:39 +0100 Date: Thu, 15 Aug 2024 15:18:37 +0100 From: Jonathan Cameron To: Keith Busch CC: , , , , Keith Busch Subject: Re: [PATCH RFC 2/8] pci: make pci_destroy_dev concurrent safe Message-ID: <20240815151837.00001330@Huawei.com> In-Reply-To: <20240722151936.1452299-3-kbusch@meta.com> References: <20240722151936.1452299-1-kbusch@meta.com> <20240722151936.1452299-3-kbusch@meta.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500003.china.huawei.com (7.191.162.67) To lhrpeml500005.china.huawei.com (7.191.163.240) On Mon, 22 Jul 2024 08:19:30 -0700 Keith Busch wrote: > From: Keith Busch > > Use an atomic flag instead of the racey check against the device's kobj > parent. We shouldn't be poking into device implementation details at > this level anyway. > > Signed-off-by: Keith Busch Reviewed-by: Jonathan Cameron Absolutely agree we shouldn't be poking the kobj parent here.