Re: [RFC PATCH 02/21] pci/doe: Define protocol types and make those public

Dan Williams
2024-08-30T02:16:02Z

Alexey Kardashevskiy wrote:
> Already public pci_doe() takes a protocol type argument.
> PCIe 6.0 defines three, define them in a header for use with pci_doe().
>
> Signed-off-by: Alexey Kardashevskiy <aik@amd.com>
> ---
> include/linux/pci-doe.h | 4 ++++
> drivers/pci/doe.c | 2 --
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/pci-doe.h b/include/linux/pci-doe.h
> index 0d3d7656c456..82e393ba5465 100644
> --- a/include/linux/pci-doe.h
> +++ b/include/linux/pci-doe.h
> @@ -13,6 +13,10 @@
> #ifndef LINUX_PCI_DOE_H
> #define LINUX_PCI_DOE_H
>
> +#define PCI_DOE_PROTOCOL_DISCOVERY 0

Why does discovery need to be global?

> +#define PCI_DOE_PROTOCOL_CMA_SPDM 1
> +#define PCI_DOE_PROTOCOL_SECURED_CMA_SPDM 2

Would be useful to have a brief idea of the consumer of these new global
definitions in the changelog.

Also you said this is based on Lukas's patches which already define
PCI_DOE_FEATURE_CMA, so lets unify that.