From: Bjorn Helgaas <helgaas@kernel.org>
To: Sergei Shtylyov <sergei.shtylyov@gmail.com>
Cc: WangYuli <wangyuli@uniontech.com>,
mathias.nyman@intel.com, gregkh@linuxfoundation.org,
bhelgaas@google.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
guanwentao@uniontech.com, zhanjun@uniontech.com,
Chen Baozi <chenbaozi@phytium.com.cn>,
Wang Zhimin <wangzhimin1179@phytium.com.cn>,
Chen Zhenhua <chenzhenhua@phytium.com.cn>,
Wang Yinfeng <wangyinfeng@phytium.com.cn>,
Jiakun Shuai <shuaijiakun1288@phytium.com.cn>
Subject: Re: [PATCH] usb: xHCI: add XHCI_RESET_ON_RESUME quirk for Phytium xHCI host
Date: Thu, 29 Aug 2024 11:51:24 -0500 [thread overview]
Message-ID: <20240829165124.GA66576@bhelgaas> (raw)
In-Reply-To: <99754b01-51a0-29d3-6022-4e25130ff36a@gmail.com>
On Thu, Aug 29, 2024 at 12:38:58PM +0300, Sergei Shtylyov wrote:
> On 8/29/24 10:30 AM, WangYuli wrote:
> > + if (pdev->vendor == PCI_VENDOR_ID_PHYTIUM ||
>
> Hm, ||, not &&?
>
> > + pdev->device == PCI_DEVICE_ID_PHYTIUM_XHCI)
> > + xhci->quirks |= XHCI_RESET_ON_RESUME;
Definitely a bug, thanks for spotting it! Must check both Vendor
*and* Device ID. There are likely unrelated devices from other
vendors using the PCI_DEVICE_ID_PHYTIUM_XHCI Device ID value.
prev parent reply other threads:[~2024-08-29 16:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 7:30 [PATCH] usb: xHCI: add XHCI_RESET_ON_RESUME quirk for Phytium xHCI host WangYuli
2024-08-29 8:46 ` Greg KH
2024-08-29 8:55 ` WangYuli
2024-08-29 9:09 ` Greg KH
2024-08-29 9:38 ` Sergei Shtylyov
2024-08-29 16:51 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240829165124.GA66576@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=chenbaozi@phytium.com.cn \
--cc=chenzhenhua@phytium.com.cn \
--cc=gregkh@linuxfoundation.org \
--cc=guanwentao@uniontech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=sergei.shtylyov@gmail.com \
--cc=shuaijiakun1288@phytium.com.cn \
--cc=wangyinfeng@phytium.com.cn \
--cc=wangyuli@uniontech.com \
--cc=wangzhimin1179@phytium.com.cn \
--cc=zhanjun@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox