From: Bjorn Helgaas <helgaas@kernel.org>
To: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
Cc: scott@spiteful.org, bhelgaas@google.com,
ilpo.jarvinen@linux.intel.com, wsa+renesas@sang-engineering.com,
lukas@wunner.de, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] PCI: hotplug: check the return of hotplug bridge
Date: Tue, 3 Sep 2024 17:39:18 -0500 [thread overview]
Message-ID: <20240903223918.GA307750@bhelgaas> (raw)
In-Reply-To: <20240831132822.22103-1-trintaeoitogc@gmail.com>
On Sat, Aug 31, 2024 at 10:28:21AM -0300, Guilherme Giacomo Simoes wrote:
> In some pci drivers, when the pci bridge is added if the process return an error,
> the drivers don't check this and continue your execute normally.
> Then, this patch change this drivers for check return of pci_hp_add_bridge(), and
> if has an error, then the drivers call goto lable , free your mutex and return the
> error for your caller.
>
> Signed-off-by: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
Did you see Lukas' response at
https://lore.kernel.org/r/ZsAzM8K9PnN5jxR9@wunner.de ?
AFAICT the discussion he pointed to is very relevant and needs to be
considered before we apply a patch like this.
If you have addressed those comments, please describe how you
addressed them in the commit log, and include links to Nam Cao's work
and cc them as well.
Bjorn
prev parent reply other threads:[~2024-09-03 22:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-31 13:28 [RESEND PATCH] PCI: hotplug: check the return of hotplug bridge Guilherme Giacomo Simoes
2024-09-03 22:39 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240903223918.GA307750@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=scott@spiteful.org \
--cc=trintaeoitogc@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox