From: "Krzysztof Wilczyński" <kw@linux.com>
To: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
Cc: linux-pci@vger.kernel.org, linux-leds@vger.kernel.org,
"Lukas Wunner" <lukas@wunner.de>,
"Christoph Hellwig" <hch@lst.de>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Stuart Hayes" <stuart.w.hayes@gmail.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Dan Williams" <dan.j.williams@intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Lee Jones" <lee@kernel.org>, "Keith Busch" <kbusch@kernel.org>,
"Marek Behun" <marek.behun@nic.cz>, "Pavel Machek" <pavel@ucw.cz>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v7 3/3] PCI/NPEM: Add _DSM PCIe SSD status LED management
Date: Fri, 6 Sep 2024 15:48:42 +0900 [thread overview]
Message-ID: <20240906064842.GE679795@rocinante> (raw)
In-Reply-To: <20240904104848.23480-4-mariusz.tkaczyk@linux.intel.com>
Hello,
Very nice series!
[...]
> +static const struct npem_ops dsm_ops = {
> + .get_active_indications = dsm_get_active_indications,
> + .set_active_indications = dsm_set_active_indications,
> + .name = "_DSM PCIe SSD Status LED Management",
A small nit: extra space.
Bjorn, we can mend this on the branch, if are OK with that.
Krzysztof
next prev parent reply other threads:[~2024-09-06 6:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 10:48 [PATCH v7 0/3] PCIe Enclosure LED Management Mariusz Tkaczyk
2024-09-04 10:48 ` [PATCH v7 1/3] leds: Init leds class earlier Mariusz Tkaczyk
2024-09-09 9:03 ` Lee Jones
2024-09-09 9:28 ` Mariusz Tkaczyk
2024-09-09 20:21 ` Lukas Wunner
2024-09-04 10:48 ` [PATCH v7 2/3] PCI/NPEM: Add Native PCIe Enclosure Management support Mariusz Tkaczyk
2024-09-04 10:48 ` [PATCH v7 3/3] PCI/NPEM: Add _DSM PCIe SSD status LED management Mariusz Tkaczyk
2024-09-06 6:48 ` Krzysztof Wilczyński [this message]
2024-09-04 22:27 ` [PATCH v7 0/3] PCIe Enclosure LED Management Bjorn Helgaas
2024-09-05 8:38 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240906064842.GE679795@rocinante \
--to=kw@linux.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kbusch@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=marek.behun@nic.cz \
--cc=mariusz.tkaczyk@linux.intel.com \
--cc=pavel@ucw.cz \
--cc=rdunlap@infradead.org \
--cc=stuart.w.hayes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox