Re: [PATCH 1/2] dt-bindings: PCI: xilinx-cpm: Add compatible string for CPM5 controller-1.

Krzysztof Kozlowski
2024-09-06T09:56:36Z

On 06/09/2024 11:31, Thippeswamy Havalige wrote:
> The Xilinx Versal premium series has CPM5 block which supports two typeA
> Root Port controller functionality at Gen5 speed.
>
> Add compatible string to distinguish between two CPM5 rootport controller1.

Subjects NEVER end with full stops.
>
> Error interrupt register and bits for both the controllers
> are at different.
>
> Signed-off-by: Thippeswamy Havalige <thippesw@amd.com>
> ---
> Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml b/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
> index 989fb0fa2577..b63a759ec2d7 100644
> --- a/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
> +++ b/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
> @@ -17,6 +17,7 @@ properties:
> enum:
> - xlnx,versal-cpm-host-1.00
> - xlnx,versal-cpm5-host
> + - xlnx,versal-cpm5-host1

That's poor naming. "-1.00" and now "1". Get your naming reasonable...

Best regards,
Krzysztof