From: "Krzysztof Wilczyński" <kw@linux.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Jinjie Ruan <ruanjinjie@huawei.com>,
joyce.ooi@intel.com, lpieralisi@kernel.org,
manivannan.sadhasivam@linaro.org, robh@kernel.org,
bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] PCI: altera: Replace TLP_REQ_ID() with macro PCI_DEVID()
Date: Wed, 11 Sep 2024 04:12:06 +0900 [thread overview]
Message-ID: <20240910191206.GB2136712@rocinante> (raw)
In-Reply-To: <20240910003029.GA554499@bhelgaas>
Hello,
[...]
> > #define TLP_READ_TAG 0x1d
> > #define TLP_WRITE_TAG 0x10
> > #define RP_DEVFN 0
> > -#define TLP_REQ_ID(bus, devfn) (((bus) << 8) | (devfn))
> > #define TLP_CFG_DW0(pcie, cfg) \
> > (((cfg) << 24) | \
> > TLP_PAYLOAD_SIZE)
> > #define TLP_CFG_DW1(pcie, tag, be) \
> > - (((TLP_REQ_ID(pcie->root_bus_nr, RP_DEVFN)) << 16) | (tag << 8) | (be))
> > + (((PCI_DEVID(pcie->root_bus_nr, RP_DEVFN)) << 16) | (tag << 8) | (be))
>
> This doesn't cause a problem per se, but PCI_DEVID() is defined
> basically as a PCI core convenience without any particular connection
> to the PCIe Requester ID format, so I don't think this is an
> improvement.
I will drop this patch based on feedback from Bjorn.
Krzysztof
prev parent reply other threads:[~2024-09-10 19:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 10:42 [PATCH -next] PCI: altera: Replace TLP_REQ_ID() with macro PCI_DEVID() Jinjie Ruan
2024-08-28 15:56 ` Manivannan Sadhasivam
2024-09-06 6:34 ` Krzysztof Wilczyński
2024-09-10 0:30 ` Bjorn Helgaas
2024-09-10 19:12 ` Krzysztof Wilczyński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240910191206.GB2136712@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=joyce.ooi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox