From: Manivannan Sadhasivam via B4 Relay <devnull+manivannan.sadhasivam.linaro.org@kernel.org>
To: "Richard Zhu" <hongxing.zhu@nxp.com>,
"Lucas Stach" <l.stach@pengutronix.de>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Chuanhua Lei" <lchuanhua@maxlinear.com>,
"Marek Vasut" <marek.vasut+renesas@gmail.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Pratyush Anand" <pratyush.anand@gmail.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>
Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
imx@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
linux-arm-msm@vger.kernel.org, abel.vesa@linaro.org,
johan+linaro@kernel.org,
Shashank Babu Chinta Venkata <quic_schintav@quicinc.com>,
linux-tegra@vger.kernel.org,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Frank Li <Frank.Li@nxp.com>
Subject: [PATCH v7 0/4] PCI: qcom: Add 16.0 GT/s equalization and margining settings
Date: Wed, 11 Sep 2024 20:56:25 +0530 [thread overview]
Message-ID: <20240911-pci-qcom-gen4-stability-v7-0-743f5c1fd027@linaro.org> (raw)
Hi,
This series adds 16.0 GT/s specific equalization and RX lane margining settings
to the Qcom RC and EP drivers. This series is mandatory for the stable operation
of the PCIe link at 16.0 GT/s on the Qcom platforms.
NOTE:
=====
I've taken over the series from Shashank based on the discussion [1]. In order
to apply the equalization/margining settings properly in the Qcom driver, I
added the first 2 patches to the series which inevitably touches other vendor
drivers also.
- Mani
Changes in v7:
- Fixed the build issue reported by Kbuild bot in patch 1/4
- Changed the logic to check invalid max_link_speed in patch 2/4
- Cleanups to patches 3/4 and 4/4 as suggested by Johan
- Added include header guard to pci-qcom-common.h
- Link to v6: https://lore.kernel.org/r/20240904-pci-qcom-gen4-stability-v6-0-ec39f7ae3f62@linaro.org
Changes in v6:
- Dropped the code refactoring patch as suggested by Johan
- Added 2 patches to fix the caching of maximum supported link speed value that
is needed to apply the equalization/margining settings
- Updated the commit message of patch 3 as per Bjorn's suggestion
For previous changelogs, please refer [2]
[1] https://lore.kernel.org/linux-pci/af65b744-7538-4929-9ab4-8ee42e17b8d1@quicinc.com/
[2] https://lore.kernel.org/linux-pci/20240821170917.21018-1-quic_schintav@quicinc.com/
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
Manivannan Sadhasivam (2):
PCI: dwc: Rename 'dw_pcie::link_gen' to 'dw_pcie::max_link_speed'
PCI: dwc: Always cache the maximum link speed value in dw_pcie::max_link_speed
Shashank Babu Chinta Venkata (2):
PCI: qcom: Add equalization settings for 16.0 GT/s
PCI: qcom: Add RX lane margining settings for 16.0 GT/s
MAINTAINERS | 4 +-
drivers/pci/controller/dwc/Kconfig | 5 ++
drivers/pci/controller/dwc/Makefile | 1 +
drivers/pci/controller/dwc/pci-imx6.c | 8 +--
drivers/pci/controller/dwc/pcie-designware.c | 22 +++++---
drivers/pci/controller/dwc/pcie-designware.h | 33 +++++++++++-
drivers/pci/controller/dwc/pcie-intel-gw.c | 4 +-
drivers/pci/controller/dwc/pcie-qcom-common.c | 78 +++++++++++++++++++++++++++
drivers/pci/controller/dwc/pcie-qcom-common.h | 14 +++++
drivers/pci/controller/dwc/pcie-qcom-ep.c | 6 +++
drivers/pci/controller/dwc/pcie-qcom.c | 6 +++
drivers/pci/controller/dwc/pcie-rcar-gen4.c | 6 +--
drivers/pci/controller/dwc/pcie-spear13xx.c | 2 +-
drivers/pci/controller/dwc/pcie-tegra194.c | 19 +++----
14 files changed, 178 insertions(+), 30 deletions(-)
---
base-commit: 47ac09b91befbb6a235ab620c32af719f8208399
change-id: 20240904-pci-qcom-gen4-stability-02ec65a7e6e4
Best regards,
--
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
next reply other threads:[~2024-09-11 15:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 15:26 Manivannan Sadhasivam via B4 Relay [this message]
2024-09-11 15:26 ` [PATCH v7 1/4] PCI: dwc: Rename 'dw_pcie::link_gen' to 'dw_pcie::max_link_speed' Manivannan Sadhasivam via B4 Relay
2024-09-11 15:26 ` [PATCH v7 2/4] PCI: dwc: Always cache the maximum link speed value in dw_pcie::max_link_speed Manivannan Sadhasivam via B4 Relay
2024-09-11 15:26 ` [PATCH v7 3/4] PCI: qcom: Add equalization settings for 16.0 GT/s Manivannan Sadhasivam via B4 Relay
2024-09-12 6:08 ` Johan Hovold
2024-09-11 15:26 ` [PATCH v7 4/4] PCI: qcom: Add RX lane margining " Manivannan Sadhasivam via B4 Relay
2024-09-12 6:10 ` Johan Hovold
2024-09-12 6:25 ` [PATCH v7 0/4] PCI: qcom: Add 16.0 GT/s equalization and margining settings Johan Hovold
2024-09-12 6:35 ` Johan Hovold
2024-09-13 22:49 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240911-pci-qcom-gen4-stability-v7-0-743f5c1fd027@linaro.org \
--to=devnull+manivannan.sadhasivam.linaro.org@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=abel.vesa@linaro.org \
--cc=bhelgaas@google.com \
--cc=festevam@gmail.com \
--cc=hongxing.zhu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=jingoohan1@gmail.com \
--cc=johan+linaro@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=kw@linux.com \
--cc=l.stach@pengutronix.de \
--cc=lchuanhua@maxlinear.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=pratyush.anand@gmail.com \
--cc=quic_schintav@quicinc.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).