From: Frank Li <Frank.Li@nxp.com>
To: "Bjorn Helgaas" <bhelgaas@google.com>,
"Richard Zhu" <hongxing.zhu@nxp.com>,
"Lucas Stach" <l.stach@pengutronix.de>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
Frank.li@nxp.com, alyssa@rosenzweig.io, bpf@vger.kernel.org,
broonie@kernel.org, jgg@ziepe.ca, joro@8bytes.org,
l.stach@pengutronix.de, lgirdwood@gmail.com, maz@kernel.org,
p.zabel@pengutronix.de, robin.murphy@arm.com, will@kernel.org,
Frank Li <Frank.Li@nxp.com>
Subject: [PATCH 1/2] PCI: Add enable_device() and disable_device() callbacks for bridges
Date: Thu, 26 Sep 2024 18:07:47 -0400 [thread overview]
Message-ID: <20240926-imx95_lut-v1-1-d0c62087dbab@nxp.com> (raw)
In-Reply-To: <20240926-imx95_lut-v1-0-d0c62087dbab@nxp.com>
Some PCIe bridges require special handling when enabling or disabling
PCIe devices. For example, on the i.MX95 platform, a lookup table must be
configured to inform the hardware how to convert pci_device_id to stream
(bus master) ID, which is used by the IOMMU and MSI controller to identify
bus master device.
Enablement will be failure when there is not enough lookup table resource.
Avoid DMA write to wrong position. That is the reason why pci_fixup_enable
can't work since not return value for fixup function.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
drivers/pci/pci.c | 19 +++++++++++++++++++
include/linux/pci.h | 2 ++
2 files changed, 21 insertions(+)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 7d85c04fbba2a..e0f83ed53d964 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -2057,6 +2057,7 @@ static int do_pci_enable_device(struct pci_dev *dev, int bars)
{
int err;
struct pci_dev *bridge;
+ struct pci_bus *bus;
u16 cmd;
u8 pin;
@@ -2068,6 +2069,15 @@ static int do_pci_enable_device(struct pci_dev *dev, int bars)
if (bridge)
pcie_aspm_powersave_config_link(bridge);
+ bus = dev->bus;
+ while (bus) {
+ if (bus->ops->enable_device)
+ err = bus->ops->enable_device(bus, dev);
+ if (err)
+ return err;
+ bus = bus->parent;
+ }
+
err = pcibios_enable_device(dev, bars);
if (err < 0)
return err;
@@ -2262,12 +2272,21 @@ void pci_disable_enabled_device(struct pci_dev *dev)
*/
void pci_disable_device(struct pci_dev *dev)
{
+ struct pci_bus *bus;
+
dev_WARN_ONCE(&dev->dev, atomic_read(&dev->enable_cnt) <= 0,
"disabling already-disabled device");
if (atomic_dec_return(&dev->enable_cnt) != 0)
return;
+ bus = dev->bus;
+ while (bus) {
+ if (bus->ops->disable_device)
+ bus->ops->disable_device(bus, dev);
+ bus = bus->parent;
+ }
+
do_pci_disable_device(dev);
dev->is_busmaster = 0;
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 573b4c4c2be61..42c25b8efd538 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -803,6 +803,8 @@ static inline int pcibios_err_to_errno(int err)
struct pci_ops {
int (*add_bus)(struct pci_bus *bus);
void (*remove_bus)(struct pci_bus *bus);
+ int (*enable_device)(struct pci_bus *bus, struct pci_dev *dev);
+ void (*disable_device)(struct pci_bus *bus, struct pci_dev *dev);
void __iomem *(*map_bus)(struct pci_bus *bus, unsigned int devfn, int where);
int (*read)(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val);
int (*write)(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val);
--
2.34.1
next prev parent reply other threads:[~2024-09-26 22:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 22:07 [PATCH 0/2] PCI: add enabe(disable)_device() hook for bridge Frank Li
2024-09-26 22:07 ` Frank Li [this message]
2024-09-28 0:07 ` [PATCH 1/2] PCI: Add enable_device() and disable_device() callbacks for bridges Bjorn Helgaas
2024-09-26 22:07 ` [PATCH 2/2] PCI: imx6: Add IOMMU and ITS MSI support for i.MX95 Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240926-imx95_lut-v1-1-d0c62087dbab@nxp.com \
--to=frank.li@nxp.com \
--cc=alyssa@rosenzweig.io \
--cc=bhelgaas@google.com \
--cc=bpf@vger.kernel.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=hongxing.zhu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=kernel@pengutronix.de \
--cc=kw@linux.com \
--cc=l.stach@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=maz@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).