From: Bjorn Helgaas <helgaas@kernel.org>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc: linux-pci@vger.kernel.org, rafael@kernel.org, lenb@kernel.org,
bhelgaas@google.com, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: acpiphp_ampere_altra: Switch back to struct platform_driver::remove()
Date: Tue, 1 Oct 2024 15:50:24 -0500 [thread overview]
Message-ID: <20241001205024.GA226037@bhelgaas> (raw)
In-Reply-To: <20240927092449.44628-1-sergio.paracuellos@gmail.com>
On Fri, Sep 27, 2024 at 11:24:49AM +0200, Sergio Paracuellos wrote:
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers.
>
> Convert all PCI controller drivers to use .remove(), with the eventual goal
> to drop struct platform_driver::remove_new(). As .remove() and .remove_new()
> have the same prototypes, conversion is done by just changing the structure
> member name in the driver initializer.
>
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Applied to pci/driver-remove for v6.13, thanks.
I also moved the controller patch to this branch so they're all
together.
> ---
> drivers/pci/hotplug/acpiphp_ampere_altra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Hi Bjorn,
>
> This is the last 'remove_new' inside 'drivers/pci' folder. Since it is
> not in controller I preferred to sent this patch alone.
>
> Thanks,
> Sergio Paracuellos
>
> diff --git a/drivers/pci/hotplug/acpiphp_ampere_altra.c b/drivers/pci/hotplug/acpiphp_ampere_altra.c
> index f5c9e741c1d4..70dbc0431fc6 100644
> --- a/drivers/pci/hotplug/acpiphp_ampere_altra.c
> +++ b/drivers/pci/hotplug/acpiphp_ampere_altra.c
> @@ -119,7 +119,7 @@ static struct platform_driver altra_led_driver = {
> .acpi_match_table = altra_led_ids,
> },
> .probe = altra_led_probe,
> - .remove_new = altra_led_remove,
> + .remove = altra_led_remove,
> };
> module_platform_driver(altra_led_driver);
>
> --
> 2.25.1
>
prev parent reply other threads:[~2024-10-01 20:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 9:24 [PATCH] PCI: acpiphp_ampere_altra: Switch back to struct platform_driver::remove() Sergio Paracuellos
2024-10-01 20:50 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241001205024.GA226037@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sergio.paracuellos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).