* [PATCH] PCI: endpoint: test: Synchronously cancel command handler work
@ 2024-10-04 14:12 Damien Le Moal
2024-10-04 22:12 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Damien Le Moal @ 2024-10-04 14:12 UTC (permalink / raw)
To: Bjorn Helgaas, Manivannan Sadhasivam, Krzysztof Wilczyński,
Kishon Vijay Abraham I, linux-pci
Cc: Niklas Cassel
Use cancel_delayed_work_sync() in pci_epf_test_epc_deinit() to ensure
that the command handler is really stopped when proceeding with dma
and bar cleanup.
The same change is also done in pci_epf_test_link_down() to ensure that
the link down handling completes with the command handler fully stopped.
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
---
drivers/pci/endpoint/functions/pci-epf-test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
index a73bc0771d35..c2e7f67e5107 100644
--- a/drivers/pci/endpoint/functions/pci-epf-test.c
+++ b/drivers/pci/endpoint/functions/pci-epf-test.c
@@ -800,7 +800,7 @@ static void pci_epf_test_epc_deinit(struct pci_epf *epf)
{
struct pci_epf_test *epf_test = epf_get_drvdata(epf);
- cancel_delayed_work(&epf_test->cmd_handler);
+ cancel_delayed_work_sync(&epf_test->cmd_handler);
pci_epf_test_clean_dma_chan(epf_test);
pci_epf_test_clear_bar(epf);
}
@@ -931,7 +931,7 @@ static void pci_epf_test_unbind(struct pci_epf *epf)
struct pci_epf_test *epf_test = epf_get_drvdata(epf);
struct pci_epc *epc = epf->epc;
- cancel_delayed_work(&epf_test->cmd_handler);
+ cancel_delayed_work_sync(&epf_test->cmd_handler);
if (epc->init_complete) {
pci_epf_test_clean_dma_chan(epf_test);
pci_epf_test_clear_bar(epf);
--
2.46.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] PCI: endpoint: test: Synchronously cancel command handler work
2024-10-04 14:12 [PATCH] PCI: endpoint: test: Synchronously cancel command handler work Damien Le Moal
@ 2024-10-04 22:12 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2024-10-04 22:12 UTC (permalink / raw)
To: Damien Le Moal
Cc: Bjorn Helgaas, Manivannan Sadhasivam, Krzysztof Wilczyński,
Kishon Vijay Abraham I, linux-pci, Niklas Cassel
On Fri, Oct 04, 2024 at 11:12:55PM +0900, Damien Le Moal wrote:
> Use cancel_delayed_work_sync() in pci_epf_test_epc_deinit() to ensure
> that the command handler is really stopped when proceeding with dma
> and bar cleanup.
>
> The same change is also done in pci_epf_test_link_down() to ensure that
> the link down handling completes with the command handler fully stopped.
s/when proceeding/before proceeding/
s/dma/DMA/
s/bar/BAR/
Whoever applies this can tweak it.
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> ---
> drivers/pci/endpoint/functions/pci-epf-test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
> index a73bc0771d35..c2e7f67e5107 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
> @@ -800,7 +800,7 @@ static void pci_epf_test_epc_deinit(struct pci_epf *epf)
> {
> struct pci_epf_test *epf_test = epf_get_drvdata(epf);
>
> - cancel_delayed_work(&epf_test->cmd_handler);
> + cancel_delayed_work_sync(&epf_test->cmd_handler);
> pci_epf_test_clean_dma_chan(epf_test);
> pci_epf_test_clear_bar(epf);
> }
> @@ -931,7 +931,7 @@ static void pci_epf_test_unbind(struct pci_epf *epf)
> struct pci_epf_test *epf_test = epf_get_drvdata(epf);
> struct pci_epc *epc = epf->epc;
>
> - cancel_delayed_work(&epf_test->cmd_handler);
> + cancel_delayed_work_sync(&epf_test->cmd_handler);
> if (epc->init_complete) {
> pci_epf_test_clean_dma_chan(epf_test);
> pci_epf_test_clear_bar(epf);
> --
> 2.46.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-04 22:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-04 14:12 [PATCH] PCI: endpoint: test: Synchronously cancel command handler work Damien Le Moal
2024-10-04 22:12 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).