* [PATCH] PCI: cpcihp: remove uneccessary field
@ 2024-10-14 13:19 Guilherme Giacomo Simoes
2024-10-16 19:46 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Guilherme Giacomo Simoes @ 2024-10-14 13:19 UTC (permalink / raw)
To: trintaeoitogc, scott, bhelgaas; +Cc: linux-pci, linux-kernel
The hardware_test field in cpci_hp_controller_ops is uneccessary because
no file is being used. How a pointer need a space in memory for storage
the address (4 bytes in 32bits systems and 8 bytes in 64 bits sustems),
remove this dead code to reduce resource consumption.
Signed-off-by: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
---
drivers/pci/hotplug/cpci_hotplug.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/hotplug/cpci_hotplug.h b/drivers/pci/hotplug/cpci_hotplug.h
index 6d8970d8c3f2..03fa39ab0c88 100644
--- a/drivers/pci/hotplug/cpci_hotplug.h
+++ b/drivers/pci/hotplug/cpci_hotplug.h
@@ -44,7 +44,6 @@ struct cpci_hp_controller_ops {
int (*enable_irq)(void);
int (*disable_irq)(void);
int (*check_irq)(void *dev_id);
- int (*hardware_test)(struct slot *slot, u32 value);
u8 (*get_power)(struct slot *slot);
int (*set_power)(struct slot *slot, int value);
};
--
2.46.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PCI: cpcihp: remove uneccessary field
2024-10-14 13:19 [PATCH] PCI: cpcihp: remove uneccessary field Guilherme Giacomo Simoes
@ 2024-10-16 19:46 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2024-10-16 19:46 UTC (permalink / raw)
To: Guilherme Giacomo Simoes; +Cc: scott, bhelgaas, linux-pci, linux-kernel
On Mon, Oct 14, 2024 at 10:19:17AM -0300, Guilherme Giacomo Simoes wrote:
> The hardware_test field in cpci_hp_controller_ops is uneccessary because
> no file is being used. How a pointer need a space in memory for storage
> the address (4 bytes in 32bits systems and 8 bytes in 64 bits sustems),
> remove this dead code to reduce resource consumption.
>
> Signed-off-by: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
Applied to pci/hotplug for v6.13, thanks!
> ---
> drivers/pci/hotplug/cpci_hotplug.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/hotplug/cpci_hotplug.h b/drivers/pci/hotplug/cpci_hotplug.h
> index 6d8970d8c3f2..03fa39ab0c88 100644
> --- a/drivers/pci/hotplug/cpci_hotplug.h
> +++ b/drivers/pci/hotplug/cpci_hotplug.h
> @@ -44,7 +44,6 @@ struct cpci_hp_controller_ops {
> int (*enable_irq)(void);
> int (*disable_irq)(void);
> int (*check_irq)(void *dev_id);
> - int (*hardware_test)(struct slot *slot, u32 value);
> u8 (*get_power)(struct slot *slot);
> int (*set_power)(struct slot *slot, int value);
> };
> --
> 2.46.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-16 19:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-14 13:19 [PATCH] PCI: cpcihp: remove uneccessary field Guilherme Giacomo Simoes
2024-10-16 19:46 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).