From: Mario Limonciello <superm1@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org (open list:PCI SUBSYSTEM),
linux-kernel@vger.kernel.org (open list),
dri-devel@lists.freedesktop.org,
Mario Limonciello <mario.limonciello@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
"Luke D . Jones" <luke@ljones.dev>
Subject: [PATCH] PCI/VGA: Don't assume only VGA device found is the boot VGA device
Date: Mon, 14 Oct 2024 10:25:02 -0500 [thread overview]
Message-ID: <20241014152502.1477809-1-superm1@kernel.org> (raw)
From: Mario Limonciello <mario.limonciello@amd.com>
The ASUS GA605W has a NVIDIA PCI VGA device and an AMD PCI display device.
```
65:00.0 VGA compatible controller: NVIDIA Corporation AD106M [GeForce RTX 4070 Max-Q / Mobile] (rev a1)
66:00.0 Display controller: Advanced Micro Devices, Inc. [AMD/ATI] Strix [Radeon 880M / 890M] (rev c1)
```
The fallback logic in vga_is_boot_device() flags the NVIDIA dGPU as the
boot VGA device, but really the eDP is connected to the AMD PCI display
device.
Drop this case to avoid marking the NVIDIA dGPU as the boot VGA device.
Suggested-by: Alex Deucher <alexander.deucher@amd.com>
Reported-by: Luke D. Jones <luke@ljones.dev>
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3673
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/pci/vgaarb.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/pci/vgaarb.c b/drivers/pci/vgaarb.c
index 78748e8d2dba..05ac2b672d4b 100644
--- a/drivers/pci/vgaarb.c
+++ b/drivers/pci/vgaarb.c
@@ -675,13 +675,6 @@ static bool vga_is_boot_device(struct vga_device *vgadev)
return true;
}
- /*
- * Vgadev has neither IO nor MEM enabled. If we haven't found any
- * other VGA devices, it is the best candidate so far.
- */
- if (!boot_vga)
- return true;
-
return false;
}
--
2.43.0
next reply other threads:[~2024-10-14 15:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 15:25 Mario Limonciello [this message]
2024-10-14 15:45 ` [PATCH] PCI/VGA: Don't assume only VGA device found is the boot VGA device Alex Deucher
2024-10-14 16:12 ` Mario Limonciello
2024-10-15 8:04 ` Luke Jones
2024-10-22 1:35 ` Kai-Heng Feng
2024-10-22 13:04 ` Alex Deucher
2024-10-23 1:27 ` Kai-Heng Feng
2024-10-23 8:27 ` Luke Jones
2024-10-23 15:27 ` Alex Deucher
2024-10-25 7:51 ` Kai-Heng Feng
2024-10-25 12:55 ` Alex Deucher
2024-10-31 0:58 ` Kai-Heng Feng
2024-10-31 10:51 ` Luke Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241014152502.1477809-1-superm1@kernel.org \
--to=superm1@kernel.org \
--cc=alexander.deucher@amd.com \
--cc=bhelgaas@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=mario.limonciello@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).