From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
linux-pci@vger.kernel.org,
"Niklas Cassel" <niklas.cassel@wdc.com>
Subject: Re: [PATCH] PCI: dwc: endpoint: Clear outbound address on unmap
Date: Tue, 15 Oct 2024 11:24:37 +0530 [thread overview]
Message-ID: <20241015055437.lq736d4ocjlb4rtn@thinkpad> (raw)
In-Reply-To: <20241004141000.5080-1-dlemoal@kernel.org>
On Fri, Oct 04, 2024 at 11:10:00PM +0900, Damien Le Moal wrote:
> In addition to clearing the atu index bit in ob_window_map, also clear
> the address mapped (outbound_addr array) in dw_pcie_ep_unmap_addr(), to
> make sure that dw_pcie_find_index() does not endup matching again an ATU
> index that was already unmapped.
>
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
> ---
> drivers/pci/controller/dwc/pcie-designware-ep.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c
> index 501e527c188e..7f4c082a2d90 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-ep.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
> @@ -294,6 +294,7 @@ static void dw_pcie_ep_unmap_addr(struct pci_epc *epc, u8 func_no, u8 vfunc_no,
> if (ret < 0)
> return;
>
> + ep->outbound_addr[atu_index] = 0;
> dw_pcie_disable_atu(pci, PCIE_ATU_REGION_DIR_OB, atu_index);
> clear_bit(atu_index, ep->ob_window_map);
> }
> --
> 2.46.2
>
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2024-10-15 5:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 14:10 [PATCH] PCI: dwc: endpoint: Clear outbound address on unmap Damien Le Moal
2024-10-04 22:10 ` Bjorn Helgaas
2024-10-15 5:54 ` Manivannan Sadhasivam [this message]
2024-10-27 20:07 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015055437.lq736d4ocjlb4rtn@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=bhelgaas@google.com \
--cc=dlemoal@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=niklas.cassel@wdc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox