From: Bjorn Helgaas <helgaas@kernel.org>
To: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
Cc: scott@spiteful.org, bhelgaas@google.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: cpcihp: remove uneccessary field
Date: Wed, 16 Oct 2024 14:46:04 -0500 [thread overview]
Message-ID: <20241016194604.GA646755@bhelgaas> (raw)
In-Reply-To: <20241014131917.324667-1-trintaeoitogc@gmail.com>
On Mon, Oct 14, 2024 at 10:19:17AM -0300, Guilherme Giacomo Simoes wrote:
> The hardware_test field in cpci_hp_controller_ops is uneccessary because
> no file is being used. How a pointer need a space in memory for storage
> the address (4 bytes in 32bits systems and 8 bytes in 64 bits sustems),
> remove this dead code to reduce resource consumption.
>
> Signed-off-by: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
Applied to pci/hotplug for v6.13, thanks!
> ---
> drivers/pci/hotplug/cpci_hotplug.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/hotplug/cpci_hotplug.h b/drivers/pci/hotplug/cpci_hotplug.h
> index 6d8970d8c3f2..03fa39ab0c88 100644
> --- a/drivers/pci/hotplug/cpci_hotplug.h
> +++ b/drivers/pci/hotplug/cpci_hotplug.h
> @@ -44,7 +44,6 @@ struct cpci_hp_controller_ops {
> int (*enable_irq)(void);
> int (*disable_irq)(void);
> int (*check_irq)(void *dev_id);
> - int (*hardware_test)(struct slot *slot, u32 value);
> u8 (*get_power)(struct slot *slot);
> int (*set_power)(struct slot *slot, int value);
> };
> --
> 2.46.2
>
prev parent reply other threads:[~2024-10-16 19:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 13:19 [PATCH] PCI: cpcihp: remove uneccessary field Guilherme Giacomo Simoes
2024-10-16 19:46 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241016194604.GA646755@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=scott@spiteful.org \
--cc=trintaeoitogc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).