Re: [PATCH] PCI: optimize proc sequential file read

[kernel test robot <lkp@intel.com>]

Hi Guixin,

kernel test robot noticed the following build errors:

[auto build test ERROR on pci/next]
[also build test ERROR on pci/for-linus linus/master v6.12-rc3 next-20241018]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Guixin-Liu/PCI-optimize-proc-sequential-file-read/20241018-135026
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link:    https://lore.kernel.org/r/20241018054728.116519-1-kanie%40linux.alibaba.com
patch subject: [PATCH] PCI: optimize proc sequential file read
config: i386-buildonly-randconfig-003-20241019 (https://download.01.org/0day-ci/archive/20241019/202410191439.yQ27wvB6-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241019/202410191439.yQ27wvB6-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410191439.yQ27wvB6-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: drivers/pci/probe.o: in function `pci_device_add':
>> drivers/pci/probe.c:2595: undefined reference to `pci_seq_tree_add_dev'
   ld: drivers/pci/remove.o: in function `pci_destroy_dev':
>> drivers/pci/remove.c:56: undefined reference to `pci_seq_tree_remove_dev'


vim +2595 drivers/pci/probe.c

  2546	
  2547	void pci_device_add(struct pci_dev *dev, struct pci_bus *bus)
  2548	{
  2549		int ret;
  2550	
  2551		pci_configure_device(dev);
  2552	
  2553		device_initialize(&dev->dev);
  2554		dev->dev.release = pci_release_dev;
  2555	
  2556		set_dev_node(&dev->dev, pcibus_to_node(bus));
  2557		dev->dev.dma_mask = &dev->dma_mask;
  2558		dev->dev.dma_parms = &dev->dma_parms;
  2559		dev->dev.coherent_dma_mask = 0xffffffffull;
  2560	
  2561		dma_set_max_seg_size(&dev->dev, 65536);
  2562		dma_set_seg_boundary(&dev->dev, 0xffffffff);
  2563	
  2564		pcie_failed_link_retrain(dev);
  2565	
  2566		/* Fix up broken headers */
  2567		pci_fixup_device(pci_fixup_header, dev);
  2568	
  2569		pci_reassigndev_resource_alignment(dev);
  2570	
  2571		dev->state_saved = false;
  2572	
  2573		pci_init_capabilities(dev);
  2574	
  2575		/*
  2576		 * Add the device to our list of discovered devices
  2577		 * and the bus list for fixup functions, etc.
  2578		 */
  2579		down_write(&pci_bus_sem);
  2580		list_add_tail(&dev->bus_list, &bus->devices);
  2581		up_write(&pci_bus_sem);
  2582	
  2583		ret = pcibios_device_add(dev);
  2584		WARN_ON(ret < 0);
  2585	
  2586		/* Set up MSI IRQ domain */
  2587		pci_set_msi_domain(dev);
  2588	
  2589		/* Notifier could use PCI capabilities */
  2590		dev->match_driver = false;
  2591		ret = device_add(&dev->dev);
  2592		WARN_ON(ret < 0);
  2593	
  2594		pci_npem_create(dev);
> 2595		pci_seq_tree_add_dev(dev);
  2596	}
  2597	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki