From: Zijun Hu <zijun_hu@icloud.com>
To: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Lee Jones <lee@kernel.org>
Cc: Zijun Hu <zijun_hu@icloud.com>,
stable@vger.kernel.org, linux-phy@lists.infradead.org,
netdev@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, Zijun Hu <quic_zijuhu@quicinc.com>
Subject: [PATCH 6/6] phy: core: Simplify API of_phy_simple_xlate() implementation
Date: Sun, 20 Oct 2024 13:27:51 +0800 [thread overview]
Message-ID: <20241020-phy_core_fix-v1-6-078062f7da71@quicinc.com> (raw)
In-Reply-To: <20241020-phy_core_fix-v1-0-078062f7da71@quicinc.com>
From: Zijun Hu <quic_zijuhu@quicinc.com>
Simplify of_phy_simple_xlate() implementation by API
class_find_device_by_of_node() which is also safer since it
subsys_get() @phy_class subsystem firstly then iterates devices.
Also comment its parameter @dev with unused in passing since the parameter
provides no available input info but acts as an auto variable.
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
drivers/phy/phy-core.c | 19 ++++++-------------
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
index 24bd619a33dd..102fc6b6ff71 100644
--- a/drivers/phy/phy-core.c
+++ b/drivers/phy/phy-core.c
@@ -748,7 +748,7 @@ EXPORT_SYMBOL_GPL(devm_phy_put);
/**
* of_phy_simple_xlate() - returns the phy instance from phy provider
- * @dev: the PHY provider device
+ * @dev: the PHY provider device unused
* @args: of_phandle_args (not used here)
*
* Intended to be used by phy provider for the common case where #phy-cells is
@@ -759,20 +759,13 @@ EXPORT_SYMBOL_GPL(devm_phy_put);
struct phy *of_phy_simple_xlate(struct device *dev,
const struct of_phandle_args *args)
{
- struct phy *phy;
- struct class_dev_iter iter;
-
- class_dev_iter_init(&iter, &phy_class, NULL, NULL);
- while ((dev = class_dev_iter_next(&iter))) {
- phy = to_phy(dev);
- if (args->np != phy->dev.of_node)
- continue;
+ struct device *target_dev;
- class_dev_iter_exit(&iter);
- return phy;
+ target_dev = class_find_device_by_of_node(&phy_class, args->np);
+ if (target_dev) {
+ put_device(target_dev);
+ return to_phy(target_dev);
}
-
- class_dev_iter_exit(&iter);
return ERR_PTR(-ENODEV);
}
EXPORT_SYMBOL_GPL(of_phy_simple_xlate);
--
2.34.1
next prev parent reply other threads:[~2024-10-20 5:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-20 5:27 [PATCH 0/6] phy: core: Fix bugs for several APIs and simplify an API Zijun Hu
2024-10-20 5:27 ` [PATCH 1/6] phy: core: Fix API devm_phy_put() can not release the phy Zijun Hu
2024-10-20 5:27 ` [PATCH 2/6] phy: core: Fix API devm_of_phy_provider_unregister() can not unregister the phy provider Zijun Hu
2024-10-20 5:27 ` [PATCH 3/6] phy: core: Fix API devm_phy_destroy() can not destroy the phy Zijun Hu
2024-10-20 5:27 ` [PATCH 4/6] phy: core: Add missing of_node_put() for an error handling path of _of_phy_get() Zijun Hu
2024-10-20 5:27 ` [PATCH 5/6] phy: core: Add missing of_node_put() in of_phy_provider_lookup() Zijun Hu
2024-10-20 7:23 ` Christophe JAILLET
2024-10-20 8:18 ` Zijun Hu
2024-10-20 5:27 ` Zijun Hu [this message]
2024-10-20 10:19 ` [PATCH 6/6] phy: core: Simplify API of_phy_simple_xlate() implementation Zijun Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241020-phy_core_fix-v1-6-078062f7da71@quicinc.com \
--to=zijun_hu@icloud.com \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=quic_zijuhu@quicinc.com \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox