Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Yuan Can <yuancan@huawei.com>
To: <bhelgaas@google.com>, <gregkh@suse.de>, <linux-pci@vger.kernel.org>
Cc: <yuancan@huawei.com>
Subject: [PATCH] PCI: cpqphp: Fix error handling in cpqhpc_init()
Date: Tue, 22 Oct 2024 17:29:17 +0800	[thread overview]
Message-ID: <20241022092917.120226-1-yuancan@huawei.com> (raw)

The cpqhpc_init() returns without checking the retval from
pci_register_driver().
If the pci_register_driver() failed, the module failed to install,
leaving the cpqhp debugfs not unregistered.

Fixes: 9f3f4681291f ("[PATCH] PCI Hotplug: fix up the sysfs file in the compaq pci hotplug driver")
Signed-off-by: Yuan Can <yuancan@huawei.com>
---
 drivers/pci/hotplug/cpqphp_core.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/pci/hotplug/cpqphp_core.c b/drivers/pci/hotplug/cpqphp_core.c
index 47a3ed16159a..933392fab8a3 100644
--- a/drivers/pci/hotplug/cpqphp_core.c
+++ b/drivers/pci/hotplug/cpqphp_core.c
@@ -1390,6 +1390,10 @@ static int __init cpqhpc_init(void)
 	cpqhp_initialize_debugfs();
 	result = pci_register_driver(&cpqhpc_driver);
 	dbg("pci_register_driver = %d\n", result);
+
+	if (result)
+		cpqhp_shutdown_debugfs();
+
 	return result;
 }
 
-- 
2.17.1


             reply	other threads:[~2024-10-22  9:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-22  9:29 Yuan Can [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-11-22 10:13 [PATCH] PCI: cpqphp: Fix error handling in cpqhpc_init() Yuan Can
2022-11-22 20:05 ` Bjorn Helgaas
2022-11-23  2:18   ` Yuan Can

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241022092917.120226-1-yuancan@huawei.com \
    --to=yuancan@huawei.com \
    --cc=bhelgaas@google.com \
    --cc=gregkh@suse.de \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox