Re: [PATCHv3 5/5] pci: unexport pci_walk_bus_locked

Keith Busch
2024-10-23T22:00:45Z

On Wed, Oct 23, 2024 at 04:43:20PM -0500, Bjorn Helgaas wrote:
> On Tue, Oct 22, 2024 at 03:48:51PM -0700, Keith Busch wrote:
> > @@ -445,7 +445,6 @@ void pci_walk_bus_locked(struct pci_bus *top, int (*cb)(struct pci_dev *, void *
> >
> > __pci_walk_bus(top, cb, userdata);
> > }
> > -EXPORT_SYMBOL_GPL(pci_walk_bus_locked);
>
> I think we could also move the declaration from include/linux/pci.h to
> drivers/pci/pci.h, right?
>
> I guess there's some argument for keeping it in include/linux/pci.h
> next to the pci_walk_bus() declaration, but I certainly don't want to
> encourage more use of either one, especially outside the PCI core.

Thanks, that's a good point! Not only are modules not using this,
neither does any kernel code outside drivers/pci/, so no need to
declare this in include/linux/.