Re: [PATCH rc] PCI: Fix pci_enable_acs() support for the ACS quirks

[Jason Gunthorpe <jgg@nvidia.com>]

On Wed, Oct 16, 2024 at 08:52:33PM -0300, Jason Gunthorpe wrote:
> There are ACS quirks that hijack the normal ACS processing and deliver to
> to special quirk code. The enable path needs to call
> pci_dev_specific_enable_acs() and then pci_dev_specific_acs_enabled() will
> report the hidden ACS state controlled by the quirk.
> 
> The recent rework got this out of order and we should try to call
> pci_dev_specific_enable_acs() regardless of any actual ACS support in the
> device.
> 
> As before command line parameters that effect standard PCI ACS don't
> interact with the quirk versions, including the new config_acs= option.
> 
> Fixes: 47c8846a49ba ("PCI: Extend ACS configurability")
> Reported-by: Jiri Slaby <jirislaby@kernel.org>
> Closes: https://lore.kernel.org/all/e89107da-ac99-4d3a-9527-a4df9986e120@kernel.org
> Closes: https://bugzilla.suse.com/show_bug.cgi?id=1229019
> Tested-by: Steffen Dirkwinkel <me@steffen.cc>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
>  drivers/pci/pci.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)

Bjorn? This was a regression?

Jason