From: Philipp Stanner <pstanner@redhat.com>
To: "Jonathan Corbet" <corbet@lwn.net>,
"Damien Le Moal" <dlemoal@kernel.org>,
"Niklas Cassel" <cassel@kernel.org>,
"Giovanni Cabiddu" <giovanni.cabiddu@intel.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
"Boris Brezillon" <bbrezillon@kernel.org>,
"Arnaud Ebalard" <arno@natisbad.org>,
"Srujana Challa" <schalla@marvell.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Miri Korenblit" <miriam.rachel.korenblit@intel.com>,
"Kalle Valo" <kvalo@kernel.org>, "Jon Mason" <jdmason@kudzu.us>,
"Dave Jiang" <dave.jiang@intel.com>,
"Allen Hubbe" <allenbh@gmail.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Kevin Cernekee" <cernekee@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Mark Brown" <broonie@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Philipp Stanner" <pstanner@redhat.com>,
"Jie Wang" <jie.wang@intel.com>,
"Michal Witwicki" <michal.witwicki@intel.com>,
"Przemek Kitszel" <przemyslaw.kitszel@intel.com>,
"Adam Guerin" <adam.guerin@intel.com>,
"Damian Muszynski" <damian.muszynski@intel.com>,
"Bharat Bhushan" <bbhushan2@marvell.com>,
"Nithin Dabilpuram" <ndabilpuram@marvell.com>,
"Johannes Berg" <johannes.berg@intel.com>,
"Emmanuel Grumbach" <emmanuel.grumbach@intel.com>,
"Benjamin Berg" <benjamin.berg@intel.com>,
"Breno Leitao" <leitao@debian.org>,
"Yedidya Benshimol" <yedidya.ben.shimol@intel.com>,
"Serge Semin" <fancer.lancer@gmail.com>,
"zhang jiao" <zhangjiao2@cmss.chinamobile.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org, qat-linux@intel.com,
linux-crypto@vger.kernel.org, linux-wireless@vger.kernel.org,
ntb@lists.linux.dev, linux-pci@vger.kernel.org,
linux-serial@vger.kernel.org, linux-sound@vger.kernel.org
Subject: [PATCH v6 03/10] crypto: qat - replace deprecated PCI functions
Date: Wed, 30 Oct 2024 12:27:36 +0100 [thread overview]
Message-ID: <20241030112743.104395-4-pstanner@redhat.com> (raw)
In-Reply-To: <20241030112743.104395-1-pstanner@redhat.com>
pcim_iomap_table() and pcim_iomap_regions_request_all() have been
deprecated by the PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate
pcim_iomap_table(), pcim_iomap_regions_request_all()").
Replace these functions with their successors, pcim_iomap() and
pcim_request_all_regions().
Signed-off-by: Philipp Stanner <pstanner@redhat.com>
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
---
drivers/crypto/intel/qat/qat_420xx/adf_drv.c | 11 ++++++++---
drivers/crypto/intel/qat/qat_4xxx/adf_drv.c | 11 ++++++++---
2 files changed, 16 insertions(+), 6 deletions(-)
diff --git a/drivers/crypto/intel/qat/qat_420xx/adf_drv.c b/drivers/crypto/intel/qat/qat_420xx/adf_drv.c
index f49818a13013..788a11cdb34b 100644
--- a/drivers/crypto/intel/qat/qat_420xx/adf_drv.c
+++ b/drivers/crypto/intel/qat/qat_420xx/adf_drv.c
@@ -129,16 +129,21 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
/* Find and map all the device's BARS */
bar_mask = pci_select_bars(pdev, IORESOURCE_MEM) & ADF_GEN4_BAR_MASK;
- ret = pcim_iomap_regions_request_all(pdev, bar_mask, pci_name(pdev));
+ ret = pcim_request_all_regions(pdev, pci_name(pdev));
if (ret) {
- dev_err(&pdev->dev, "Failed to map pci regions.\n");
+ dev_err(&pdev->dev, "Failed to request PCI regions.\n");
goto out_err;
}
i = 0;
for_each_set_bit(bar_nr, &bar_mask, PCI_STD_NUM_BARS) {
bar = &accel_pci_dev->pci_bars[i++];
- bar->virt_addr = pcim_iomap_table(pdev)[bar_nr];
+ bar->virt_addr = pcim_iomap(pdev, bar_nr, 0);
+ if (!bar->virt_addr) {
+ dev_err(&pdev->dev, "Failed to ioremap PCI region.\n");
+ ret = -ENOMEM;
+ goto out_err;
+ }
}
pci_set_master(pdev);
diff --git a/drivers/crypto/intel/qat/qat_4xxx/adf_drv.c b/drivers/crypto/intel/qat/qat_4xxx/adf_drv.c
index 659905e45950..115eabfd1f6b 100644
--- a/drivers/crypto/intel/qat/qat_4xxx/adf_drv.c
+++ b/drivers/crypto/intel/qat/qat_4xxx/adf_drv.c
@@ -131,16 +131,21 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
/* Find and map all the device's BARS */
bar_mask = pci_select_bars(pdev, IORESOURCE_MEM) & ADF_GEN4_BAR_MASK;
- ret = pcim_iomap_regions_request_all(pdev, bar_mask, pci_name(pdev));
+ ret = pcim_request_all_regions(pdev, pci_name(pdev));
if (ret) {
- dev_err(&pdev->dev, "Failed to map pci regions.\n");
+ dev_err(&pdev->dev, "Failed to request PCI regions.\n");
goto out_err;
}
i = 0;
for_each_set_bit(bar_nr, &bar_mask, PCI_STD_NUM_BARS) {
bar = &accel_pci_dev->pci_bars[i++];
- bar->virt_addr = pcim_iomap_table(pdev)[bar_nr];
+ bar->virt_addr = pcim_iomap(pdev, bar_nr, 0);
+ if (!bar->virt_addr) {
+ dev_err(&pdev->dev, "Failed to ioremap PCI region.\n");
+ ret = -ENOMEM;
+ goto out_err;
+ }
}
pci_set_master(pdev);
--
2.47.0
next prev parent reply other threads:[~2024-10-30 11:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 11:27 [PATCH v6 00/10] Remove pcim_iomap_regions_request_all() Philipp Stanner
2024-10-30 11:27 ` [PATCH v6 01/10] PCI: Make pcim_request_all_regions() a public function Philipp Stanner
2024-10-30 11:27 ` [PATCH v6 02/10] ata: ahci: Replace deprecated PCI functions Philipp Stanner
2024-10-30 11:27 ` Philipp Stanner [this message]
2024-10-30 11:27 ` [PATCH v6 04/10] crypto: marvell - replace " Philipp Stanner
2024-10-30 11:27 ` [PATCH v6 05/10] intel_th: pci: Replace " Philipp Stanner
2024-10-30 11:27 ` [PATCH v6 06/10] wifi: iwlwifi: replace " Philipp Stanner
2024-10-30 11:27 ` [PATCH v6 07/10] ntb: idt: Replace " Philipp Stanner
2024-10-30 11:27 ` [PATCH v6 08/10] serial: rp2: " Philipp Stanner
2024-10-30 11:27 ` [PATCH v6 09/10] ALSA: korg1212: " Philipp Stanner
2024-10-30 11:27 ` [PATCH v6 10/10] PCI: Remove pcim_iomap_regions_request_all() Philipp Stanner
2024-10-30 21:11 ` [PATCH v6 00/10] " Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241030112743.104395-4-pstanner@redhat.com \
--to=pstanner@redhat.com \
--cc=adam.guerin@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=allenbh@gmail.com \
--cc=arno@natisbad.org \
--cc=bbhushan2@marvell.com \
--cc=bbrezillon@kernel.org \
--cc=benjamin.berg@intel.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=cassel@kernel.org \
--cc=cernekee@gmail.com \
--cc=corbet@lwn.net \
--cc=damian.muszynski@intel.com \
--cc=dave.jiang@intel.com \
--cc=davem@davemloft.net \
--cc=dlechner@baylibre.com \
--cc=dlemoal@kernel.org \
--cc=emmanuel.grumbach@intel.com \
--cc=fancer.lancer@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=giovanni.cabiddu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jdmason@kudzu.us \
--cc=jie.wang@intel.com \
--cc=jirislaby@kernel.org \
--cc=johannes.berg@intel.com \
--cc=kvalo@kernel.org \
--cc=leitao@debian.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.witwicki@intel.com \
--cc=miriam.rachel.korenblit@intel.com \
--cc=ndabilpuram@marvell.com \
--cc=ntb@lists.linux.dev \
--cc=perex@perex.cz \
--cc=przemyslaw.kitszel@intel.com \
--cc=qat-linux@intel.com \
--cc=schalla@marvell.com \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yedidya.ben.shimol@intel.com \
--cc=zhangjiao2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).