From: Leon Romanovsky <leon@kernel.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Jens Axboe" <axboe@kernel.dk>, "Jason Gunthorpe" <jgg@ziepe.ca>,
"Robin Murphy" <robin.murphy@arm.com>,
"Joerg Roedel" <joro@8bytes.org>, "Will Deacon" <will@kernel.org>,
"Christoph Hellwig" <hch@lst.de>,
"Sagi Grimberg" <sagi@grimberg.me>,
"Keith Busch" <kbusch@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Logan Gunthorpe" <logang@deltatee.com>,
"Yishai Hadas" <yishaih@nvidia.com>,
"Shameer Kolothum" <shameerali.kolothum.thodi@huawei.com>,
"Kevin Tian" <kevin.tian@intel.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Jonathan Corbet" <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org, linux-rdma@vger.kernel.org,
iommu@lists.linux.dev, linux-nvme@lists.infradead.org,
linux-pci@vger.kernel.org, kvm@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [RFC PATCH 2/7] block: don't merge different kinds of P2P transfers in a single bio
Date: Fri, 1 Nov 2024 08:11:16 +0200 [thread overview]
Message-ID: <20241101061116.GC88858@unreal> (raw)
In-Reply-To: <d4378502-6bc2-4064-8c35-191738105406@acm.org>
On Thu, Oct 31, 2024 at 01:58:37PM -0700, Bart Van Assche wrote:
> On 10/27/24 7:21 AM, Leon Romanovsky wrote:
> > + /*
> > + * When doing ZONE_DEVICE-based P2P transfers, all pages in a
> > + * bio must be P2P pages from the same device.
> > + */
> > + if ((bio->bi_opf & REQ_P2PDMA) &&
> > + !zone_device_pages_have_same_pgmap(bv->bv_page, page))
> > + return 0;
>
> It's probably too late to change the "zone_device_" prefix into
> something that cannot be confused with a reference to zoned block
> devices?
It is never too late to send a patch which renames the names, but it needs
to be worth it. However it is hard to see global benefit from zone_device_* rename.
ZONE_DEVICE is a well known term in the kernel and it is used all other places
in the kernel.
Thanks
>
> Thanks,
>
> Bart.
>
next prev parent reply other threads:[~2024-11-01 6:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-27 14:21 [RFC PATCH 0/7] Block and NMMe PCI use of new DMA mapping API Leon Romanovsky
2024-10-27 14:21 ` [RFC PATCH 1/7] block: share more code for bio addition helpers Leon Romanovsky
2024-10-31 20:55 ` Bart Van Assche
2024-11-04 8:55 ` Christoph Hellwig
2024-10-27 14:21 ` [RFC PATCH 2/7] block: don't merge different kinds of P2P transfers in a single bio Leon Romanovsky
2024-10-28 18:27 ` Logan Gunthorpe
2024-10-31 20:58 ` Bart Van Assche
2024-11-01 6:11 ` Leon Romanovsky [this message]
2024-11-04 8:55 ` Christoph Hellwig
2024-11-02 7:39 ` Zhu Yanjun
2024-11-03 15:19 ` Leon Romanovsky
2024-11-04 8:56 ` Christoph Hellwig
2024-10-27 14:21 ` [RFC PATCH 3/7] blk-mq: add a dma mapping iterator Leon Romanovsky
2024-10-27 14:21 ` [RFC PATCH 4/7] blk-mq: add scatterlist-less DMA mapping helpers Leon Romanovsky
2024-10-27 14:21 ` [RFC PATCH 5/7] nvme-pci: remove struct nvme_descriptor Leon Romanovsky
2024-10-27 14:21 ` [RFC PATCH 6/7] nvme-pci: use a better encoding for small prp pool allocations Leon Romanovsky
2024-10-27 14:22 ` [RFC PATCH 7/7] nvme-pci: convert to blk_rq_dma_map Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241101061116.GC88858@unreal \
--to=leon@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=bvanassche@acm.org \
--cc=corbet@lwn.net \
--cc=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=joro@8bytes.org \
--cc=kbusch@kernel.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=sagi@grimberg.me \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=will@kernel.org \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).