Re: [PATCH] pci:endpoint Remove redundant returns

Krzysztof Wilczyński
2024-11-04T13:53:45Z

Hello,

> [+Cc linux-pci mailing list]
>
> > In fact, void function return statements are not generally useful.
>
> ... unless used within the code for control flow. :)
>
> > dma_release_channel(epf_test->dma_chan_rx);
> > epf_test->dma_chan_rx = NULL;
> > -
> > - return;
>
> Makes sense.
>
> For reference, this surplus return statement was added in the commit
> 8353813c88ef ("PCI: endpoint: Enable DMA tests for endpoints with DMA
> capabilities").

Applied to endpoint, thank you!

[01/01] PCI: endpoint: Remove surplus return statement from pci_epf_test_clean_dma_chan()
https://git.kernel.org/pci/pci/c/3fdf564b21d3

Krzysztof