From: Bjorn Helgaas <helgaas@kernel.org>
To: "Krzysztof Wilczyński" <kw@linux.com>
Cc: 2564278112@qq.com, manivannan.sadhasivam@linaro.org,
kishon@kernel.org, bhelgaas@google.com, cassel@kernel.org,
Frank.Li@nxp.com, dlemoal@kernel.org, jiangwang@kylinos.cn,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] pci:endpoint Remove redundant returns
Date: Mon, 4 Nov 2024 17:46:57 -0600 [thread overview]
Message-ID: <20241104234657.GA1446698@bhelgaas> (raw)
In-Reply-To: <20241104133500.GD2504924@rocinante>
On Mon, Nov 04, 2024 at 10:35:00PM +0900, Krzysztof Wilczyński wrote:
> Hello,
>
> [+Cc linux-pci mailing list]
Where did this patch come from? I don't see it on the mailing list,
so there's no signed-off-by chain for it, and the Link in the commit
doesn't go to the patch posting.
Please post all PCI-related patches to linux-pci@vger.kernel.org.
> > In fact, void function return statements are not generally useful.
>
> ... unless used within the code for control flow. :)
>
> > dma_release_channel(epf_test->dma_chan_rx);
> > epf_test->dma_chan_rx = NULL;
> > -
> > - return;
>
> Makes sense.
>
> For reference, this surplus return statement was added in the commit
> 8353813c88ef ("PCI: endpoint: Enable DMA tests for endpoints with DMA
> capabilities").
>
> Krzysztof
next prev parent reply other threads:[~2024-11-04 23:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tencent_1039A1784512AF88CA1844804F7DEC059407@qq.com>
2024-11-04 13:35 ` [PATCH] pci:endpoint Remove redundant returns Krzysztof Wilczyński
2024-11-04 13:53 ` Krzysztof Wilczyński
2024-11-04 23:46 ` Bjorn Helgaas [this message]
2024-11-05 0:43 ` Krzysztof Wilczyński
2024-11-05 8:50 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241104234657.GA1446698@bhelgaas \
--to=helgaas@kernel.org \
--cc=2564278112@qq.com \
--cc=Frank.Li@nxp.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=jiangwang@kylinos.cn \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox