From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5533C1DEFE7 for ; Wed, 6 Nov 2024 17:09:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730912942; cv=none; b=bqDkX+Iosn6ieaRKAmhEtXNkylq0V1nptyUTZ7fLe1MumVzdzjt3ED9Jt1scapgCqrObrJ1eWnAiTDLii7BgQhsyzQTCscquafyOVa6Hzmi2weLEeial7mabP1daf4yW8eY7XzYwNScpD6mxgAi3ig8LEVqikwGtuqEbLtdhjE0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730912942; c=relaxed/simple; bh=lUtU6exFV/0t2K0nFD83dUTyPPvOKmzMlR2+lgOJ6QA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jF9dKoI9kxDnrYYmRH8E/zLv+rMLLkC67yBiSHfs35IZIlIpwUnpCmEThxJJhqUmyMW9WFdxW0IviR4t34qnECg1utk2uY5ZeXir+DhJDgnsImPJ3Pq5sHOc4s85xsJftvFJ6ACTydzswavvFODSvywxeewcusDNbsadfxwNOxU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=N/DgUSiY; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="N/DgUSiY" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a99f3a5a44cso909180566b.3 for ; Wed, 06 Nov 2024 09:09:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730912939; x=1731517739; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=J6eDnsApgHXXX2eNqrPT459Y8vwvHutnUiY5z69lIwY=; b=N/DgUSiYMBtMsnL5i8eVB2h80AVSJN8YVrvFJ6hlbM7bTXRyFZ6mRy34idwiM6e38r qGyaYmyVk7AXZcP5/MSztof2avfE8zMptzoyw1c7pWk1Su10jnFHvo0gwDln3plN6HnS T8leGnJGsU0DuZ+xszb0tprfC3ms0FLrJ02fdjPK0ybj4kC81B4yJT5+bvzENa3dfAMi eO4SzIA+1iZTDtkbT1c891hZgxJI9i7qNB13dJuFv6qVfeqBPD3MdTCce/b4KTkpNlyp cnCoHAL9x6YFYuj5oySeRQvpdC9bmkqfrY2iyTUWODRBAy5p5A8XtlZ5FhTxMKa+zQmy 4sIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730912939; x=1731517739; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=J6eDnsApgHXXX2eNqrPT459Y8vwvHutnUiY5z69lIwY=; b=TySkIzi4nrKVOeuD0zvwSM89LYn2FFoZOBv1GMdQrZhbZAC3ByNPT8MzXITM8il3lj qJ3v8sUZ3Vsa0UULrWSIlG2Kg22Mr0oKqrXsIodKURL98Hp+6XoWg/gNcCKtMkfiL9fH 5sHQy8fe7/Q+DrwqZAub2z8qcHrGzEbQWb+yPLh9iuuskLFzIveHmvDKkM4r0CUeGzr6 LuUUdMbCLT998d1YG27qLTg/5DflzQoo3ivn7mkVAovTeWjUVawOGERjqh9Ep617cjpr ZFvMHlCUFZ2ZJ4W9pbRE3hCzF8IU5npZBLbJMBJI7BZ85Dv6+YxfJMcOkMhiXzxD7EZb DCwg== X-Forwarded-Encrypted: i=1; AJvYcCUaYwj4QcstnwPPjtNnNnVkG6OqB4TJYvYtCc54CxwPyyRbn7aGPs6EYo49/KlTrPW0zrV4LT/T3hQ=@vger.kernel.org X-Gm-Message-State: AOJu0YynBRETtNrp4BoiSkpqgrr9KGMrjRXhu/WBTTHHxpCY8r1NjCB2 XaPi0Ra2VCiCzkAcJDanTWJO3R7PwrVhOB8VFIV/t4EFDtGXbiqXj8HNt9Aulw== X-Google-Smtp-Source: AGHT+IFuDYP4MNuKTvCz+cqkpbEel3mPAHGXPas8WurjLlxHRsA6YcT5W5N/fyHtAoT/QJOJ2VQgxw== X-Received: by 2002:a17:906:7305:b0:a9e:c267:2040 with SMTP id a640c23a62f3a-a9ec2672423mr402543566b.51.1730912938575; Wed, 06 Nov 2024 09:08:58 -0800 (PST) Received: from thinkpad ([89.101.134.25]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9eb16a2ec7sm311191266b.22.2024.11.06.09.08.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Nov 2024 09:08:57 -0800 (PST) Date: Wed, 6 Nov 2024 17:08:56 +0000 From: Manivannan Sadhasivam To: Bjorn Helgaas Cc: Sricharan R , bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V7 4/4] PCI: qcom: Add support for IPQ9574 Message-ID: <20241106170856.7iv2sjmjwyhnurps@thinkpad> References: <20241106145615.25tc7n4zcdkp47jr@thinkpad> <20241106165312.GA1528877@bhelgaas> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241106165312.GA1528877@bhelgaas> On Wed, Nov 06, 2024 at 10:53:12AM -0600, Bjorn Helgaas wrote: > On Wed, Nov 06, 2024 at 02:56:15PM +0000, Manivannan Sadhasivam wrote: > > On Tue, Nov 05, 2024 at 07:40:24PM -0600, Bjorn Helgaas wrote: > > > On Thu, Aug 01, 2024 at 11:18:03AM +0530, Sricharan R wrote: > > > > From: devi priya > > > > > > > > The IPQ9574 platform has four Gen3 PCIe controllers: > > > > two single-lane and two dual-lane based on SNPS core 5.70a. > > > > > > > > QCOM IP rev is 1.27.0 and Synopsys IP rev is 5.80a. > > > > Reuse all the members of 'ops_2_9_0'. > > > > > > Wow, this is confusing. > > > > > > "Based on SNPS core 5.70a", but "Synopsys IP rev is 5.80a." > > > Are those supposed to match? Or is it 5.70a of one thing but 5.80a of > > > a different thing? > > > > Hmm, I'm not sure why 5.70a is mentioned here. It seems irrelevant > > (even if it is the base). > > > > > And where does ops_2_9_0 come in? The code comment says: > > > > > > /* Qcom IP rev.: 2.9.0 Synopsys IP rev.: 5.00a */ > > > static const struct qcom_pcie_ops ops_2_9_0 = { > > > > > > which doesn't match 1.27.0 or 5.70a or 5.80a. In fact there's nothing > > > in the file that matches 1.*27.*0 > > > > > > Honestly, I don't really care if you have all the versions here in the > > > commit log. But if the versions *are* here, can we make them make > > > sense? > > > > We name the 'ops' structure based on Qcom IP revision. And we reuse > > it across the SoCs which are compatible. That's why ops_2_9_0 is > > used for this SoC which has Qcom IP rev 1.27.0. > > Got it. So a family of compatible Qcom IP starts with 2.9.0 and newer > members are 1.27.0 etc. With no hint in the source about what the > members of the family are. Perfect sEnSe. > You can get that information by mapping the ops structure with compatibles. I feel less incentive in documenting the SoC names deriving the same IP. And the reason why 2.9.0 ops is used by 1.27 is because, we ended up adding support for 2.9.0 IP first and the lower version followed later. - Mani -- மணிவண்ணன் சதாசிவம்