Re: [PATCH] PCI: mvebu: Use for_each_of_range() iterator for parsing "ranges"

Rob Herring
2025-02-18T22:32:54Z

On Sun, Feb 16, 2025 at 10:54 AM Pali Rohár <pali@kernel.org> wrote:
>
> On Friday 15 November 2024 13:01:04 Manivannan Sadhasivam wrote:
> > On Thu, Nov 07, 2024 at 09:32:55AM -0600, Rob Herring (Arm) wrote:
> > > The mvebu "ranges" is a bit unusual with its own encoding of addresses,
> > > but it's still just normal "ranges" as far as parsing is concerned.
> > > Convert mvebu_get_tgt_attr() to use the for_each_of_range() iterator
> > > instead of open coding the parsing.
> > >
> > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> >
> > LGTM!
> >
> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> >
> > Could someone please verify it on mvebu machine?
> >
> > - Mani
>
> That is mostly impossible as pci-mvebu is broken. Bjorn and Krzysztof in
> past already refused to take patches which would fix the driver or
> extend it for other platforms.

That makes no sense. The driver is broken and we won't take patches to fix it.

> So I do not understand why you are rewriting something which worked,
> instead of fixing something which is broken. The only point can be to
> make driver even more broken...

We make coding improvements to the kernel code all the time. There is
no way folks can test every platform. Either drivers need to get
tested at some frequency or they should just be removed until someone
cares enough to maintain them.

Rob