Re: [PATCH net-next] eth: fbnic: Add PCIe hardware statistics

Jakub Kicinski
2024-11-07T15:40:11Z

On Thu, 7 Nov 2024 14:03:57 +0200 Leon Romanovsky wrote:
> > [root@host ~]# ethtool -i eth0 | grep driver
> > driver: mlx5_core
> > [root@host ~]# ethtool -S eth0 | grep pci
> > rx_pci_signal_integrity: 1
> > tx_pci_signal_integrity: 1471
> > outbound_pci_stalled_rd: 0
> > outbound_pci_stalled_wr: 0
> > outbound_pci_stalled_rd_events: 0
> > outbound_pci_stalled_wr_events: 0
> >
> > Isn't it a PCIe statistics?
>
> I didn't do full archaeological research and stopped at 2017 there these
> counters were updated to use new API, but it looks like they there from
> stone age.
>
> It was a mistake to put it there and they should be moved to PCI core
> together with other hundreds debug counters which ConnectX devices have
> but don't expose yet.

Whatever hand-waving you do now, it's impossible to take you seriously
where the device driver of which you are a maintainer does the same
thing. And your direction going forward for PCIe debug, AFAIU, is the
proprietary fwctl stuff. Please stop.