From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50FE9192B69; Thu, 7 Nov 2024 08:34:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730968483; cv=none; b=IVvndwG8eBPJMAQXyAvY5pI2gtrayAC99reBHXqDa7Xxb5eQu03zJPJ9NYVxcHxXbQiBvz1CPUyonzNtdM8zw9MQnPAGt2BhcGoaZdC6kqOl4IwcvP33uNPlAbiOEDABdOs38RsA3kSZ3aZwh9VK5f3goDO7awG2uBqYn293gIY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730968483; c=relaxed/simple; bh=e1p9ZMW7teYCEnbCKcr1SaIZsmbiLbiyA0aRfo9a4ng=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PS6GY/cQS0uaKnegFAL7hsh4yqqT9bnay08SJtw6oRXTnkfGVPcQSFbD8dh6o8JDDjI/LGpyeSG+B87bb+tsPww+4SwhdGiyVzOp2fG9ARK44LsNyoY0DNWQAQj0HCBUyqMgeJWJmjYf2GMWgStD4kBqWLu/IttBt8gygPYrTZU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=n6o8yfVV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="n6o8yfVV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16723C4CECC; Thu, 7 Nov 2024 08:34:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1730968482; bh=e1p9ZMW7teYCEnbCKcr1SaIZsmbiLbiyA0aRfo9a4ng=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n6o8yfVVzmP20CgAlHC9dO6b6jCFk6MgXPjL9Xt708u/Lxa5ohHyLuEUPDXjOnrm6 jAWaEtiFQRTbehBE99yF3/kBiLR0OFHNbb7ol1rWyHcsXA70CmdFGd/pdldVwKOgGv AJPcjsF08vfT35481CPZl7hydXp8/QQhlEyuvJII= Date: Thu, 7 Nov 2024 09:17:44 +0100 From: Greg Kroah-Hartman To: Pavankumar Kondeti Cc: Joerg Roedel , Will Deacon , Robin Murphy , Bjorn Helgaas , Joerg Roedel , Rob Herring , Marek Szyprowski , Anders Roxell , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Xingang Wang Subject: Re: [PATCH RESEND] iommu/of: Fix pci_request_acs() before enumerating PCI devices Message-ID: <2024110759-refusal-mayflower-2522@gregkh> References: <20241107-pci_acs_fix-v1-1-185a2462a571@quicinc.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241107-pci_acs_fix-v1-1-185a2462a571@quicinc.com> On Thu, Nov 07, 2024 at 01:29:15PM +0530, Pavankumar Kondeti wrote: > From: Xingang Wang > > When booting with devicetree, the pci_request_acs() is called after the > enumeration and initialization of PCI devices, thus the ACS is not > enabled. And ACS should be enabled when IOMMU is detected for the > PCI host bridge, so add check for IOMMU before probe of PCI host and call > pci_request_acs() to make sure ACS will be enabled when enumerating PCI > devices. > > Fixes: 6bf6c24720d33 ("iommu/of: Request ACS from the PCI core when configuring IOMMU linkage") > Signed-off-by: Xingang Wang > Signed-off-by: Pavankumar Kondeti > --- > Earlier this patch made it to linux-next but got dropped later as it > broke PCI on ARM Juno R1 board. AFAICT, this issue is never root caused, > so resending this patch to get attention again. > > https://lore.kernel.org/all/1621566204-37456-1-git-send-email-wangxingang5@huawei.com/ Please don't resend known-broken patches. Please fix them up before resending, otherwise we will just ignore this one as well as obviously we can not take such a thing (nor should you want us to.) thanks, greg k-h