public inbox for linux-pci@vger.kernel.org
 help / color / mirror / Atom feed
From: Krishna chaitanya chundru <quic_krichai@quicinc.com>
To: "Kevin Xie" <kevin.xie@starfivetech.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
	"Rob Herring" <robh@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>
Cc: <Markus.Elfring@web.de>, <quic_mrana@quicinc.com>,
	<rafael@kernel.org>, <m.szyprowski@samsung.com>,
	<linux-pm@vger.kernel.org>, <linux-pci@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	"Krishna chaitanya chundru" <quic_krichai@quicinc.com>
Subject: [PATCH v7 1/2] PCI: starfive: Enable PCIe controller's runtime PM before probing host bridge
Date: Mon, 11 Nov 2024 14:11:52 +0530	[thread overview]
Message-ID: <20241111-runtime_pm-v7-1-9c164eefcd87@quicinc.com> (raw)
In-Reply-To: <20241111-runtime_pm-v7-0-9c164eefcd87@quicinc.com>

From: Mayank Rana <quic_mrana@quicinc.com>

PCIe controller device (i.e. PCIe starfive device) is parent to PCIe host
bridge device. To enable runtime PM of PCIe host bridge device (child
device), it is must to enable parent device's runtime PM to avoid seeing
the below warning from PM core:

pcie-starfive 940000000.pcie: Enabling runtime PM for inactive device
with active children

Fix this issue by enabling starfive pcie controller device's runtime PM
before calling pci_host_probe() in plda_pcie_host_init().

Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Mayank Rana <quic_mrana@quicinc.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
v3->v6:
- no change
Link to v3: https://patchwork.kernel.org/project/linux-pci/patch/20241014162607.1247611-1-quic_mrana@quicinc.com/
v2->v3:
- Update commit description based on Mani's feedback
- Updated Reviewed-by tag
Link to v2: https://patchwork.kernel.org/project/linux-pci/patch/20241011235530.3919347-1-quic_mrana@quicinc.com/

v1->v2: Updated commit description based on Bjorn's feedback
Link to v1: https://patchwork.kernel.org/project/linux-pci/patch/20241010202950.3263899-1-quic_mrana@quicinc.com/
---
 drivers/pci/controller/plda/pcie-starfive.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/pci/controller/plda/pcie-starfive.c b/drivers/pci/controller/plda/pcie-starfive.c
index c9933ecf6833..0564fdce47c2 100644
--- a/drivers/pci/controller/plda/pcie-starfive.c
+++ b/drivers/pci/controller/plda/pcie-starfive.c
@@ -404,6 +404,9 @@ static int starfive_pcie_probe(struct platform_device *pdev)
 	if (ret)
 		return ret;
 
+	pm_runtime_enable(&pdev->dev);
+	pm_runtime_get_sync(&pdev->dev);
+
 	plda->host_ops = &sf_host_ops;
 	plda->num_events = PLDA_MAX_EVENT_NUM;
 	/* mask doorbell event */
@@ -413,11 +416,12 @@ static int starfive_pcie_probe(struct platform_device *pdev)
 	plda->events_bitmap <<= PLDA_NUM_DMA_EVENTS;
 	ret = plda_pcie_host_init(&pcie->plda, &starfive_pcie_ops,
 				  &stf_pcie_event);
-	if (ret)
+	if (ret) {
+		pm_runtime_put_sync(&pdev->dev);
+		pm_runtime_disable(&pdev->dev);
 		return ret;
+	}
 
-	pm_runtime_enable(&pdev->dev);
-	pm_runtime_get_sync(&pdev->dev);
 	platform_set_drvdata(pdev, pcie);
 
 	return 0;

-- 
2.34.1


  reply	other threads:[~2024-11-11  8:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-11  8:41 [PATCH v7 0/2] PCI: Enable runtime pm of the host bridge Krishna chaitanya chundru
2024-11-11  8:41 ` Krishna chaitanya chundru [this message]
2024-11-11  8:41 ` [PATCH v7 2/2] " Krishna chaitanya chundru
2024-11-11 16:46   ` Markus Elfring
2024-11-13  5:24     ` Krishna Chaitanya Chundru
2025-01-07 13:19   ` Johan Hovold
2025-01-07 14:10     ` Krishna Chaitanya Chundru
2025-01-07 14:27       ` Johan Hovold
2025-01-13 16:25         ` Manivannan Sadhasivam
2025-01-14 21:16           ` Bjorn Helgaas
2025-01-19 15:29             ` Manivannan Sadhasivam
2025-01-20 10:29               ` Johan Hovold
2025-01-20 15:28                 ` Manivannan Sadhasivam
2025-01-21 13:18                   ` Johan Hovold
2025-01-21 13:34                     ` Johan Hovold
2025-01-24  5:15                     ` Manivannan Sadhasivam
2025-01-27 14:31           ` Ulf Hansson
2025-01-27 19:57             ` Rafael J. Wysocki
2025-01-28 11:47               ` Rafael J. Wysocki
2025-01-28 15:58                 ` Manivannan Sadhasivam
2025-01-28 16:07                   ` Rafael J. Wysocki
2024-11-12 23:44 ` [PATCH v7 0/2] " Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241111-runtime_pm-v7-1-9c164eefcd87@quicinc.com \
    --to=quic_krichai@quicinc.com \
    --cc=Markus.Elfring@web.de \
    --cc=bhelgaas@google.com \
    --cc=kevin.xie@starfivetech.com \
    --cc=kw@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=quic_mrana@quicinc.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox