From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B7B61F7066 for ; Tue, 12 Nov 2024 00:35:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731371711; cv=none; b=Jew5x2wvI4u94olH+QGXc4LquTosPRkl55G8upBtigJijNumNqVqXw4I3FbhbpugP3ZsFaSQ5O0K6AlYo4CC3D+rMBSbjFxM0i/Fp5ar140oJ8C3f9eyiR2bH5obSC1Qznc+HcltjWAq85YltXFAZYaJ0aUZikDOvVoxZ7xA85k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731371711; c=relaxed/simple; bh=PkbyTMgFqOzcboehWlrrNjFh8Q2ib415gbHXRRFnbKA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lHG/VOVj408i+ydn/VFAwBHNTgh6MxF/E1yp/4dwwtRqv7ZBkKWkKwavnhS/AB9XBRu9tNvpfeRfgBJCPkHRyOmlHXDLIQLYIk8FvuW7lxPuhfoGlmIg9OOGcx2Ik8Avb55X9VV0sS84YkZMq40hfIjHj6RZmMZ9suCnqW7ENeY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org; spf=pass smtp.mailfrom=networkplumber.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b=XtuK8EZ5; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b="XtuK8EZ5" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-20c693b68f5so52173385ad.1 for ; Mon, 11 Nov 2024 16:35:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1731371709; x=1731976509; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=EKgRrgLp424rRp+9+I/8Qg6L1UWiV8NeCx/IXJG06O4=; b=XtuK8EZ5k0B8EVS8lRpTMmyiSJxFc1EDkFbTXoxtx9vK6MIba3rfrQYXjWN4wCFgNl KVmV1YCHOlYfFs91bgsD5uZfXAX2RtJjDeT5rAGeWRHZS5wdYsjwH7xLuEdpLPFcbS2i 0IFXutOvz/P3fbHTY9RqSw8+v7wu2cqAI6sSRjsB9m9KrgMI+7BhShgk+hVKxn7R12Gw FvhakkkgAhhjzy9SjtneVLmShHgl8tPNP1GUspDLXlM4IUJswOKOb9n1DzDBRptwLjXd oNS9iSJ52FDxMepWV3f7L+2kvu6QuoeEdICOfnTthmTbqKslZ2P9BqzkPrw2Wp2twy07 xTPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731371709; x=1731976509; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EKgRrgLp424rRp+9+I/8Qg6L1UWiV8NeCx/IXJG06O4=; b=KyMsNgQEODZqIC59mi80VafyAqlYEdBFP1Q8LUzyxpAjot7NWmER3VfEL/hlsaOiH7 rpIz7ymX2XnPWwjQkOHH8gnFnqYneCeuTagjz0O8ZT2fRW0oDoPcuz/sPkKQQknZV1PB DtcDU7AKeImO0loeD3NHlnCcsU+An+vQ8yagLNICsni2GYFddK3q1RU0Y2glN4tmfAyo cOPrYNXFHbBwa3xhAAupyRkXVLDJve3t2KURNa0HTCjuh7kPUW3m+mkS0HYuTlHnw//e L88GbRbgLd+bIp/rKyjuj0fSYtIc4jZPtdb8eYCxks/Iq/IqVcOZxYM15UvVASob+DSf vdEA== X-Forwarded-Encrypted: i=1; AJvYcCXg9H3AXffJEXm4FFKLvmX+jxHu6xwtypzUwXkh8Eu68Bg7bVhpxjiESJlTzGq/hTHTTcgjszQhOAo=@vger.kernel.org X-Gm-Message-State: AOJu0Ywp3gEMUF/jlouhT0WSp4L9PQ2kcpL3nDAzOS07+1fVrn5TM/fZ +zeJI3t3GzlkK1N+Q+m6Xke9S8Qkgv+vP31aXW94v3F4GN7L9O7GjQ70LKs4yIA= X-Google-Smtp-Source: AGHT+IGQTUP7sJ930EzsgxemjH6kwFcSH2PpZgSrP5gAgxNP+jgwhKNTZv9LbZwLWAoEXjOkZzUgZw== X-Received: by 2002:a17:902:d4d0:b0:20b:ab4b:5432 with SMTP id d9443c01a7336-211834f2d6bmr134631535ad.12.1731371709530; Mon, 11 Nov 2024 16:35:09 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21177dc8376sm82809975ad.44.2024.11.11.16.35.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2024 16:35:09 -0800 (PST) Date: Mon, 11 Nov 2024 16:34:30 -0800 From: Stephen Hemminger To: Bjorn Helgaas Cc: Leon Romanovsky , Leon Romanovsky , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , linux-pci@vger.kernel.org, Ariel Almog , Aditya Prabhune , Hannes Reinecke , Heiner Kallweit , Arun Easi , Jonathan Chocron , Bert Kenward , Matt Carlson , Kai-Heng Feng , Jean Delvare , Alex Williamson , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v1 1/2] PCI/sysfs: Change read permissions for VPD attributes Message-ID: <20241111163430.7fad2a2a@hermes.local> In-Reply-To: <20241111204104.GA1817395@bhelgaas> References: <20241111204104.GA1817395@bhelgaas> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 11 Nov 2024 14:41:04 -0600 Bjorn Helgaas wrote: > On Thu, Nov 07, 2024 at 08:56:56PM +0200, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > The Vital Product Data (VPD) attribute is not readable by regular > > user without root permissions. Such restriction is not really needed > > for many devices in the world, as data presented in that VPD is not > > sensitive and access to the HW is safe and tested. > > > > This change aligns the permissions of the VPD attribute to be accessible > > for read by all users, while write being restricted to root only. > > > > For the driver, there is a need to opt-in in order to allow this > > functionality. > > I don't think the use case is very strong (and not included at all > here). > > If we do need to do this, I think it's a property of the device, not > the driver. I remember some broken PCI devices, which will crash if VPD is read. Probably not worth opening this can of worms.