Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@meta.com>
To: <linux-pci@vger.kernel.org>
Cc: <bhelgaas@google.com>, <lukas@wunner.de>,
	Keith Busch <kbusch@kernel.org>
Subject: [PATCH] pci: always clear pme on stop
Date: Mon, 11 Nov 2024 10:06:59 -0800	[thread overview]
Message-ID: <20241111180659.3321671-1-kbusch@meta.com> (raw)

From: Keith Busch <kbusch@kernel.org>

This used to be called unconditionally, but was inadvertently changed to
call it only once. Restore the previously existing behavior.

Fixes: 6d6d962a8dc2 ("pci: make pci_stop_dev concurrent safe")
Suggested-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
 drivers/pci/remove.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/remove.c b/drivers/pci/remove.c
index 2e940101ce1bf..36467558c0144 100644
--- a/drivers/pci/remove.c
+++ b/drivers/pci/remove.c
@@ -31,10 +31,10 @@ static int pci_pwrctl_unregister(struct device *dev, void *data)
 
 static void pci_stop_dev(struct pci_dev *dev)
 {
+	pci_pme_active(dev, false);
+
 	if (!pci_dev_test_and_clear_added(dev))
 		return;
-
-	pci_pme_active(dev, false);
 	device_for_each_child(dev->dev.parent, dev_of_node(&dev->dev),
 			      pci_pwrctl_unregister);
 	device_release_driver(&dev->dev);
-- 
2.43.5


             reply	other threads:[~2024-11-11 18:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-11 18:06 Keith Busch [this message]
2024-11-11 19:06 ` [PATCH] pci: always clear pme on stop Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241111180659.3321671-1-kbusch@meta.com \
    --to=kbusch@meta.com \
    --cc=bhelgaas@google.com \
    --cc=kbusch@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox