From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA93B1A01D8 for ; Tue, 12 Nov 2024 07:08:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731395324; cv=none; b=asINmji1sv2hVEcw07F4OAccofBwMZb1seQsOXZreKP1igxB/zjsFdJgfEhO8aVKiM8qDYLi80bdlll8oFXITydk/4OdOS7bovb+sxVM5KwC9twR218OGov3ypl/SpzgFWRCCqtV3VxIPiSd5xxLLqCqdkKmhltqCM1hkEZXt0g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731395324; c=relaxed/simple; bh=vQpLr73fPAhyt03b7DbuAYrhHB/HfoQbi+CkELdcpO0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Dp/1n59PllZAA8kjh/QlQQ+u4Z4kFxYQDwLsKxj0EnBYMMXwj8sl8YzwzWCXjLgtPjS7f++4RP3TXWGUxIW4T28ENafI7+Z5Zz9U+YIvfDluasq2NkxuJT6Tbty08CcwA6jW/8E+/+4iuX18D1cMPB+6lxloP98qY1MY2X0jqOk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wVJmn2Fc; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wVJmn2Fc" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-720d5ada03cso5368502b3a.1 for ; Mon, 11 Nov 2024 23:08:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1731395322; x=1732000122; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=GYotEMBcArnksOWpjr0ougrZeUumVFiWesABvsp9ubM=; b=wVJmn2FcDREXPawtIwjpevNGPVIB0METJpU83ImusUEzJmQ15IEgjKCZgL6BNiY7Vu KxMNL8uJzcgIogK1tFRgAS2oRn9Gihnj8S3eRYBVFn6lPfroF0IeS+kNn45wbfaScVm0 onvZ+rgN18OaPw4kj/rG6L5QIKiGqupX4F6qyVnqaCvbqVyTP7bKeNM5vPppeoSQD/Rh wvBNaYd/ozs9bUayIj/PuRho95JHtK5klANjZau2CWc3A4P3IRg98zha8WuhOtAFQOuy E0M0QHgsYwMWI9g6HuHOVAxD9m+GqeiO9gGMSRaEa5oejbul4YS6gdghmouQyGY5FX0d Urkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731395322; x=1732000122; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GYotEMBcArnksOWpjr0ougrZeUumVFiWesABvsp9ubM=; b=daLDXPfAzlVP8ba/NReStgj8pHxHDL7mJ35r5XFvpNptsr8ofjb7n0tt95YzgyUdM0 x2SLiFHTZqgB2lxz9q5gd90M7MFu1EPjCbR1CZnIOQC7ifMzFFfcbknkHip/NnD15YW4 cx0pUNCm/xHKlM6icSzsJ6ItVoP3JVsVVR9vcEI3RWI/fclS3L0UXzRKOGblCGNS/z2n 4F7ByXWa3O/X1zmQaGpAnZGm84hJY+biUL8zS4DxEiJYEiwKh/jTYK6OnPlV5JHVCn/l ojl2RmWnnjPPoYA+uUIn3kK6TXm8dYssR44smY36M+qdRIfCXRYGRmPexppcr+C3yIQO QAXw== X-Forwarded-Encrypted: i=1; AJvYcCWXx8lLfH/K+6Ayi1/+h+E8H/1Yz8hUK8eCfLiam5nobiVklu87c6qkWvF/J5TvGtVaxOGH/WBqg2w=@vger.kernel.org X-Gm-Message-State: AOJu0YxDyPs/xwh9oWtKaZ/rk0ZPqD7EagbOCbyfG4y46nYCegGUwS8j 7CVJdXkmz8ufYvGR8GfdhhTR1aZvg7wcejxSAvm19AGJEDYqdzIUjDlDlvNN7w== X-Google-Smtp-Source: AGHT+IEgoR8vcVl0tRHfaHi7w/ESUdKFgKdOZs0ADUUkeKDj40lQwin0LYfqby4SbBaVUfu+WzSmOA== X-Received: by 2002:a05:6a00:4f93:b0:71e:6c65:e7c4 with SMTP id d2e1a72fcca58-7241339e122mr18485552b3a.26.1731395322004; Mon, 11 Nov 2024 23:08:42 -0800 (PST) Received: from thinkpad ([117.213.103.248]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7240799bb25sm10714175b3a.109.2024.11.11.23.08.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2024 23:08:41 -0800 (PST) Date: Tue, 12 Nov 2024 12:38:34 +0530 From: Manivannan Sadhasivam To: Zijun Hu Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Frank Li , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Zijun Hu , stable@vger.kernel.org Subject: Re: [PATCH v2 2/2] PCI: endpoint: Fix API pci_epc_remove_epf() cleaning up wrong EPC of EPF Message-ID: <20241112070834.ttnmue5bfu6lnxdb@thinkpad> References: <20241107-epc_rfc-v2-0-da5b6a99a66f@quicinc.com> <20241107-epc_rfc-v2-2-da5b6a99a66f@quicinc.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241107-epc_rfc-v2-2-da5b6a99a66f@quicinc.com> On Thu, Nov 07, 2024 at 08:53:09AM +0800, Zijun Hu wrote: > From: Zijun Hu > > It is wrong for pci_epc_remove_epf(..., epf, SECONDARY_INTERFACE) to > clean up @epf->epc obviously. > > Fix by cleaning up @epf->sec_epc instead of @epf->epc for > SECONDARY_INTERFACE. > > Fixes: 63840ff53223 ("PCI: endpoint: Add support to associate secondary EPC with EPF") > Cc: stable@vger.kernel.org > Signed-off-by: Zijun Hu Reviewed-by: Manivannan Sadhasivam - Mani > --- > drivers/pci/endpoint/pci-epc-core.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/endpoint/pci-epc-core.c b/drivers/pci/endpoint/pci-epc-core.c > index bcc9bc3d6df5..62f7dff43730 100644 > --- a/drivers/pci/endpoint/pci-epc-core.c > +++ b/drivers/pci/endpoint/pci-epc-core.c > @@ -660,18 +660,18 @@ void pci_epc_remove_epf(struct pci_epc *epc, struct pci_epf *epf, > if (IS_ERR_OR_NULL(epc) || !epf) > return; > > + mutex_lock(&epc->list_lock); > if (type == PRIMARY_INTERFACE) { > func_no = epf->func_no; > list = &epf->list; > + epf->epc = NULL; > } else { > func_no = epf->sec_epc_func_no; > list = &epf->sec_epc_list; > + epf->sec_epc = NULL; > } > - > - mutex_lock(&epc->list_lock); > clear_bit(func_no, &epc->function_num_map); > list_del(list); > - epf->epc = NULL; > mutex_unlock(&epc->list_lock); > } > EXPORT_SYMBOL_GPL(pci_epc_remove_epf); > > -- > 2.34.1 > -- மணிவண்ணன் சதாசிவம்