From: Daniel Wagner <wagi@kernel.org>
To: "Jens Axboe" <axboe@kernel.dk>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Keith Busch" <kbusch@kernel.org>,
"Christoph Hellwig" <hch@lst.de>,
"Sagi Grimberg" <sagi@grimberg.me>,
"John Garry" <john.g.garry@oracle.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Hannes Reinecke" <hare@suse.de>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, virtualization@lists.linux.dev,
linux-scsi@vger.kernel.org, megaraidlinux.pdl@broadcom.com,
mpi3mr-linuxdrv.pdl@broadcom.com,
MPT-FusionLinux.pdl@broadcom.com, storagedev@microchip.com,
linux-nvme@lists.infradead.org, Daniel Wagner <wagi@kernel.org>
Subject: [PATCH v4 05/10] blk-mq: introduce blk_mq_hctx_map_queues
Date: Wed, 13 Nov 2024 15:26:19 +0100 [thread overview]
Message-ID: <20241113-refactor-blk-affinity-helpers-v4-5-dd3baa1e267f@kernel.org> (raw)
In-Reply-To: <20241113-refactor-blk-affinity-helpers-v4-0-dd3baa1e267f@kernel.org>
blk_mq_pci_map_queues and blk_mq_virtio_map_queues will create a CPU to
hardware queue mapping based on affinity information. These two function
share common code and only differ on how the affinity information is
retrieved. Also, those functions are located in the block subsystem
where it doesn't really fit in. They are virtio and pci subsystem
specific.
Thus introduce provide a generic mapping function which uses the
irq_get_affinity callback from bus_type.
Originally idea from Ming Lei <ming.lei@redhat.com>
Signed-off-by: Daniel Wagner <wagi@kernel.org>
---
block/blk-mq-cpumap.c | 43 +++++++++++++++++++++++++++++++++++++++++++
include/linux/blk-mq.h | 2 ++
2 files changed, 45 insertions(+)
diff --git a/block/blk-mq-cpumap.c b/block/blk-mq-cpumap.c
index 9638b25fd52124f0173e968ebdca5f1fe0b42ad9..3506f1c25a02d331d28212a2a97fb269cb21e738 100644
--- a/block/blk-mq-cpumap.c
+++ b/block/blk-mq-cpumap.c
@@ -11,6 +11,7 @@
#include <linux/smp.h>
#include <linux/cpu.h>
#include <linux/group_cpus.h>
+#include <linux/device/bus.h>
#include "blk.h"
#include "blk-mq.h"
@@ -54,3 +55,45 @@ int blk_mq_hw_queue_to_node(struct blk_mq_queue_map *qmap, unsigned int index)
return NUMA_NO_NODE;
}
+
+/**
+ * blk_mq_hctx_map_queues - Create CPU to hardware queue mapping
+ * @qmap: CPU to hardware queue map.
+ * @dev: The device to map queues.
+ * @offset: Queue offset to use for the device.
+ *
+ * Create a CPU to hardware queue mapping in @qmap. The struct bus_type
+ * irq_get_affinity callback will be used to retrieve the affinity.
+ */
+void blk_mq_hctx_map_queues(struct blk_mq_queue_map *qmap,
+ struct device *dev, unsigned int offset)
+
+{
+ const struct cpumask *(*irq_get_affinity)(struct device *dev,
+ unsigned int irq_vec);
+ const struct cpumask *mask;
+ unsigned int queue, cpu;
+
+ if (dev->driver->irq_get_affinity)
+ irq_get_affinity = dev->driver->irq_get_affinity;
+ else if (dev->bus->irq_get_affinity)
+ irq_get_affinity = dev->bus->irq_get_affinity;
+ else
+ goto fallback;
+
+ for (queue = 0; queue < qmap->nr_queues; queue++) {
+ mask = irq_get_affinity(dev, queue + offset);
+ if (!mask)
+ goto fallback;
+
+ for_each_cpu(cpu, mask)
+ qmap->mq_map[cpu] = qmap->queue_offset + queue;
+ }
+
+ return;
+
+fallback:
+ WARN_ON_ONCE(qmap->nr_queues > 1);
+ blk_mq_clear_mq_map(qmap);
+}
+EXPORT_SYMBOL_GPL(blk_mq_hctx_map_queues);
diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index 2035fad3131fb60781957095ce8a3a941dd104be..1a85fdcb443c154390cd29f2b1f2a807bf10bfe3 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -923,6 +923,8 @@ void blk_mq_unfreeze_queue_non_owner(struct request_queue *q);
void blk_freeze_queue_start_non_owner(struct request_queue *q);
void blk_mq_map_queues(struct blk_mq_queue_map *qmap);
+void blk_mq_hctx_map_queues(struct blk_mq_queue_map *qmap,
+ struct device *dev, unsigned int offset);
void blk_mq_update_nr_hw_queues(struct blk_mq_tag_set *set, int nr_hw_queues);
void blk_mq_quiesce_queue_nowait(struct request_queue *q);
--
2.47.0
next prev parent reply other threads:[~2024-11-13 14:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 14:26 [PATCH v4 00/10] blk: refactor queue affinity helpers Daniel Wagner
2024-11-13 14:26 ` [PATCH v4 01/10] driver core: bus: add irq_get_affinity callback to bus_type Daniel Wagner
2024-11-14 1:45 ` Ming Lei
2024-11-13 14:26 ` [PATCH v4 02/10] driver core: add irq_get_affinity callback device_driver Daniel Wagner
2024-11-14 1:52 ` Ming Lei
2024-11-14 7:06 ` Daniel Wagner
2024-11-13 14:26 ` [PATCH v4 03/10] PCI: hookup irq_get_affinity callback Daniel Wagner
2024-11-14 1:53 ` Ming Lei
2024-11-13 14:26 ` [PATCH v4 04/10] virtio: " Daniel Wagner
2024-11-14 1:54 ` Ming Lei
2024-11-13 14:26 ` Daniel Wagner [this message]
2024-11-14 1:58 ` [PATCH v4 05/10] blk-mq: introduce blk_mq_hctx_map_queues Ming Lei
2024-11-14 7:54 ` Daniel Wagner
2024-11-14 9:12 ` Ming Lei
2024-11-14 12:06 ` Daniel Wagner
2024-11-14 12:11 ` Christoph Hellwig
2024-11-14 12:20 ` John Garry
2024-11-13 14:26 ` [PATCH v4 06/10] scsi: replace blk_mq_pci_map_queues with blk_mq_hctx_map_queues Daniel Wagner
2024-11-13 14:26 ` [PATCH v4 07/10] scsi: hisi_sas: use blk_mq_hctx_map_queues to map queues Daniel Wagner
2024-11-14 0:36 ` kernel test robot
2024-11-14 7:08 ` Daniel Wagner
2024-11-14 3:28 ` kernel test robot
2024-11-13 14:26 ` [PATCH v4 08/10] nvme: replace blk_mq_pci_map_queues with blk_mq_hctx_map_queues Daniel Wagner
2024-11-13 14:26 ` [PATCH v4 09/10] virtio: blk/scsi: replace blk_mq_virtio_map_queues " Daniel Wagner
2024-11-13 14:26 ` [PATCH v4 10/10] blk-mq: remove unused queue mapping helpers Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241113-refactor-blk-affinity-helpers-v4-5-dd3baa1e267f@kernel.org \
--to=wagi@kernel.org \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=eperezma@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jasowang@redhat.com \
--cc=john.g.garry@oracle.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=mpi3mr-linuxdrv.pdl@broadcom.com \
--cc=mst@redhat.com \
--cc=sagi@grimberg.me \
--cc=storagedev@microchip.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox