From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA9F31BC08B for ; Fri, 15 Nov 2024 14:00:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731679225; cv=none; b=ZwTWeAop8M5SE0cPVKKbzyHX4GUzrvdgHesPaV1qESNBWJqfSgK8nX99EqYreaSrxntpDkQxRo/oxvcYLJ/Tt2ZgzJ3TSaHK7OTPeTWi2w/vKglIlm+4CK3gV7ZCeqFY6S1mlz7+r63RryUKvbV9f8Lznm+090eReD7+eKxn5UU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731679225; c=relaxed/simple; bh=wITQEuGHifPLZfrjNBLGf1/VYU3ldYv0BLlgjaO4tNI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I+f0X3YUReYbhvJBGjlwSgFCym/cIWFYIIcqZi/wYCmcbt4wcN61r7MQJtCxFPxi/Zc6xQNbsXvVwEB7cn5ShR3MuihLWdlvWmczcK/NEOGNEee2/VfihcO0AyH7Hg3zSCzYT7yP2GQsjovgSd6USA7i2141Rzu7ibVOvDD7Wlc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DQiE5xHB; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DQiE5xHB" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-7f8c7ca7f3cso349546a12.2 for ; Fri, 15 Nov 2024 06:00:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1731679222; x=1732284022; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=wfpzUgAKV0jqCB/bxXS4WblmHJxx7PtLijC6sKxlHnQ=; b=DQiE5xHBvOw4lA8aOTP9hmVR3UpC6iAPMWAthWcmEChe8KH+ny9oRM6dixWaU3t5bx JAYzS8mFJ3GYln/Uq7Jxx8FKCppUhAb3wvKz5fluVaWp454Z5wnThX7Au50hhwttVjAB N4BZmk7xsOUNrskDp1+Z10Su7VJ1nDUkKt0N+BAIYcRfBGiodsvWEEYFZIfi1QwFkfhd e1Yoke2NLfQylFqXctNbKdC+5gU/msGhPsEDgwuHtVQC/kvEWVWpt64Lb8JpbVLoxknh jfkrYgWo6anebDwpOKXR9e0lvZCQqOTUGi9OIHLtQ4yOmu73a5TMsmjkIsMqFWpX9hrA zXyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731679222; x=1732284022; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wfpzUgAKV0jqCB/bxXS4WblmHJxx7PtLijC6sKxlHnQ=; b=EngNKmwRl3CWwLCiSdpoaK+HkrKqtacLXOICDxRAQayeg10O+3fmk7IBTeDxR2g/4y epy+F0QeqT/fmk1nUIktLanrd3dhGfwJ3kdwR8S8pUcAwzZu7CgS+LOHZt7rVhZet//G VXDH+aaMbszPOw9PchH8ueoL3gcSlHGgvcHK1OHW7Px9sfhmWmeMyflfd6pEhplwCcX0 u4UmbCNotrGDIUhULG551H9gqv3naUn25IoDoxJSzzEDs+jFT3RguTaQY4gt15XPjdqq 22r2tVaXd3FqH58n3M0hPJntfFJanWs0YrhAXulSQKe/Ei4TFg7/jyq6GXPF41u4Q2aU X5RA== X-Forwarded-Encrypted: i=1; AJvYcCV75DCwvknSznaulKF80e/w39yK6DnXey+5gEGnQNu1TQC348+A3cw1/2qZCSu8j6saoYO9HwCDTTY=@vger.kernel.org X-Gm-Message-State: AOJu0YznDLynoB1g+5Nvm68+WY7GpiX7EBkZ47UJUC2YBeN62+oMgMzx U0Cb79CipDdPFGPXZxh+KTJyK2mZ8GoRCa8mH4cypWY1Guca51dqtKEvYCsj8w== X-Google-Smtp-Source: AGHT+IF2wtEKwXutObdUBNcfljb4mzMuPVgleqWOzqod5ZcyZXK+6BYBJljNVhpODn7AtoJMoCNd5Q== X-Received: by 2002:a05:6a20:729b:b0:1dc:154a:81fb with SMTP id adf61e73a8af0-1dc90c05ecdmr3582385637.44.1731679221986; Fri, 15 Nov 2024 06:00:21 -0800 (PST) Received: from thinkpad ([117.193.215.93]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724770ee81csm1362494b3a.32.2024.11.15.06.00.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Nov 2024 06:00:21 -0800 (PST) Date: Fri, 15 Nov 2024 19:30:13 +0530 From: Manivannan Sadhasivam To: Krishna chaitanya chundru Cc: Jingoo Han , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Konrad Dybcio , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , quic_vbadigan@quicinc.com, quic_mrana@quicinc.com, andersson@kernel.org Subject: Re: [PATCH v4 2/3] PCI: qcom: Set linkup_irq if global IRQ handler is present Message-ID: <20241115140013.ichb3ntic6jicsy5@thinkpad> References: <20241115-remove_wait1-v4-0-7e3412756e3d@quicinc.com> <20241115-remove_wait1-v4-2-7e3412756e3d@quicinc.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241115-remove_wait1-v4-2-7e3412756e3d@quicinc.com> On Fri, Nov 15, 2024 at 04:00:22PM +0530, Krishna chaitanya chundru wrote: > In cases where a global IRQ handler is present to manage link up > interrupts, it may not be necessary to wait for the link to be up > during PCI initialization which optimizes the bootup time. > > So, set use_linkup_irq flag if global IRQ is present and In order to set s/In/in > the use_linkup_irq flag before calling dw_pcie_host_init() API, which > waits for link to be up, move platform_get_irq_byname_optional() API s/API/call > above dw_pcie_host_init(). > > Signed-off-by: Krishna chaitanya chundru Reviewed-by: Manivannan Sadhasivam - Mani > --- > drivers/pci/controller/dwc/pcie-qcom.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index ef44a82be058..c39d1c55b50e 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -1692,6 +1692,10 @@ static int qcom_pcie_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, pcie); > > + irq = platform_get_irq_byname_optional(pdev, "global"); > + if (irq > 0) > + pp->use_linkup_irq = true; > + > ret = dw_pcie_host_init(pp); > if (ret) { > dev_err(dev, "cannot initialize host\n"); > @@ -1705,7 +1709,6 @@ static int qcom_pcie_probe(struct platform_device *pdev) > goto err_host_deinit; > } > > - irq = platform_get_irq_byname_optional(pdev, "global"); > if (irq > 0) { > ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, > qcom_pcie_global_irq_thread, > > -- > 2.34.1 > -- மணிவண்ணன் சதாசிவம்