Re: [PATCH] PCI: dwc: ep: Fix advertised resizable BAR size again

Krzysztof Wilczyński
2024-11-16T18:14:07Z

Hello,

On 24-11-16 01:59:51, Niklas Cassel wrote:
> The advertised resizable BAR size was fixed in commit 72e34b8593e0 ("PCI:
> dwc: endpoint: Fix advertised resizable BAR size").
>
> Commit 867ab111b242 ("PCI: dwc: ep: Add a generic dw_pcie_ep_linkdown() API
> to handle Link Down event") was included shortly after this, and moved the
> code to another function. When the code was moved, this fix was mistakenly
> lost.
>
> According to the spec, it is illegal to not have a bit set in
> PCI_REBAR_CAP, and 1 MB is the smallest size allowed.
>
> Set bit 4 in PCI_REBAR_CAP, so that we actually advertise support for a
> 1 MB BAR size.

Applied to controller/dwc, thank you!

[01/01] PCI: dwc: ep: Fix advertised resizable BAR size regression
https://git.kernel.org/pci/pci/c/ead24c08af48

Krzysztof