Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: kernel test robot <lkp@intel.com>
Cc: linux-pci@vger.kernel.org,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Damien Le Moal" <dlemoal@kernel.org>
Subject: Re: [pci:controller/rockchip] BUILD SUCCESS 592aac418ebdf451fe9b146bc2ca6dfc96921af0
Date: Tue, 19 Nov 2024 09:19:25 -0600	[thread overview]
Message-ID: <20241119151925.GA2263235@bhelgaas> (raw)
In-Reply-To: <202411180006.ahFN8muC-lkp@intel.com>

On Mon, Nov 18, 2024 at 12:01:12AM +0800, kernel test robot wrote:
> tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git controller/rockchip
> branch HEAD: 592aac418ebdf451fe9b146bc2ca6dfc96921af0  PCI: rockchip-ep: Handle PERST# signal in endpoint mode

> x86_64                           allyesconfig    clang-19

How can I reproduce this build?  Do you have a packaged clang-19
toolchain?

The x86_64 allyesconfig build succeeded for the robot, but when I
build on x86_64 with gcc-11.4.0, I get an error:

  $ gcc -v
  gcc version 11.4.0 (Ubuntu 11.4.0-1ubuntu1~22.04)
  $ git checkout 592aac418ebd
  $ make allyesconfig
  $ make drivers/pci/controller/pcie-rockchip-ep.o
    CC      drivers/pci/controller/pcie-rockchip-ep.o
  drivers/pci/controller/pcie-rockchip-ep.c:640:9: error: implicit declaration of function ‘irq_set_irq_type’

irq_set_irq_type() is declared in <linux/irq.h>.  On arm64, where this
driver is used, <linux/irq.h> is included via this path:

  linux/pci.h
    linux/interrupt.h
      linux/hardirq.h
	arch/arm64/include/asm/hardirq.h
	  asm-generic/hardirq.h
	    linux/irq.h

but on x86, arch/x86/include/asm/hardirq.h does not include
asm-generic/hardirq.h and therefore doesn't include <linux/irq.h>.

I'm confused about why the robot reported a successful build with
clang-19.  It seems like that should have the same problem I saw with
gcc, so I'd like to try it manually.

Bjorn

  reply	other threads:[~2024-11-19 15:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-17 16:01 [pci:controller/rockchip] BUILD SUCCESS 592aac418ebdf451fe9b146bc2ca6dfc96921af0 kernel test robot
2024-11-19 15:19 ` Bjorn Helgaas [this message]
2024-11-19 18:02   ` Krzysztof Wilczyński
2024-11-21  3:00   ` Damien Le Moal
2024-11-21  4:37   ` Philip Li
2024-11-21  7:59     ` Philip Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241119151925.GA2263235@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox