From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED70C1D0B95 for ; Tue, 19 Nov 2024 17:10:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732036245; cv=none; b=YKI+m2tL+rHTD2BSeIGGJqAxAx+/mDlfSJbUFQPLE07pUgAkal7/LolXMgYydPOCbblRweaHcwE/P0eRe2nyKHlMojrs3/EZWQnt3s7m77E+YM9F5R/yTNjCBNWqTBy/9XvNEC8xjtHc9zHDDrG13u/slOs9wXL1a7nO548Zyhc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732036245; c=relaxed/simple; bh=kvLbJ579ZwGw3Oaztv7AZcVCN5b4MH15HVGgmcj/8IM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BDyP63tpWxyX6u4EvNjShhoZ79xIgRemJWmuNlTi4QUgBIiEE+EMzCayKFS1iZUCnkp9XK/ZhM0E1Yr27sTiAK9mXYXqdCSd05GjzcWhz6jLO019EbjO+A7AZUKq7pR/EkvmJMq2mtvGZl1M8ijyHoY2lpqIGSXcSDSK/vCCGcQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=cR/KpTDE; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cR/KpTDE" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-7f450f7f11dso2549333a12.2 for ; Tue, 19 Nov 2024 09:10:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732036243; x=1732641043; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=iUUWg+UGhAfZ69jZ3O5Hxqi/tTrKLMmbgFAb621AXyg=; b=cR/KpTDEgBQGSMM9IX/9DcjhRtrjBECc4DLuL++mrfhj6BYnu/PJXqxmD3ZjPBPqtf vD5AIaHmNPfxic9TDtIZz6KN/MY96olvObj7Xs4bhAf2aR8+1u6hEzZj8sgtNkoSw/A2 Wpp/vatU9zB1qp1K88sLHDjkUdItS8+nBr5PTEjwHFUuSRktdjEjJo7sQHenxKwzGcE1 X8wX+8Aa7F7DCceXmJXgWAWnA1jOZt9FlpjY2G3ltZC3R2ykk597Q80tZLpPndrhL27J moBoXxO31JMfvQ/KMBYTxPnEXck7DjooJsE88jn3qnI7t+hh2uENKoJGCY1q3/oTeYbB 8x8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732036243; x=1732641043; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iUUWg+UGhAfZ69jZ3O5Hxqi/tTrKLMmbgFAb621AXyg=; b=PrEALIPDHkSViex+AICS44NMDdW4nvc0ZG9UDRpCK+qunsy6FeIUvhaRGYlDy0VM+o XS0uJ9P26qei7d6+yprwjj16t/ap+s4LdLG6HGQZbQ/6+aG86Hq84H6mZuS//obOjadL vkySGL6atjSBPmIAj+rznVpY4AVeyvaj7SCuROHi+eYqZhX+hNNyJf6Vqkvx4aX4BxgW nG74XN4CLplBbDp1h4FDhYqQrMIefLgo6OmAZ+Ri9b2Drk3WZgOnJL4+XuGvsS6Y01+S nxdHpglXnEP+woiyA/I7LMQEsLf49Pk4jUwm5LdXmffeXB9GqnR9Wwo7EnCK9CbgP8nV H2zg== X-Forwarded-Encrypted: i=1; AJvYcCUXs845BC0OsbjBa2yQPV8HsV19RUbONz2v+WJ30OghezgRIpR+uSgpEXi24fFnsEQVFQagweWBNxg=@vger.kernel.org X-Gm-Message-State: AOJu0Yw61jokmJgZ5TmStN7tnFTgx2xJJxIspTZ646CA7XqaJ4b1MLQU NdG+fSTQRJwFUbdfkbb89TIKqqk5dkH+A0Ax5HiYEbRypX+kQ+umqx9jj5kWTQ== X-Google-Smtp-Source: AGHT+IE7E3Zp2kHPwg5lXWa8INvXlJxcFdphad7gNVjXAQACkRCQ/vp5YyEU16SHnGc89YQPOSIJpw== X-Received: by 2002:a17:90b:3c52:b0:2ea:95ac:54d1 with SMTP id 98e67ed59e1d1-2ea95ac56damr6412420a91.19.1732036243274; Tue, 19 Nov 2024 09:10:43 -0800 (PST) Received: from thinkpad ([36.255.17.169]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ea499aff4esm5636614a91.34.2024.11.19.09.10.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Nov 2024 09:10:42 -0800 (PST) Date: Tue, 19 Nov 2024 22:40:37 +0530 From: Manivannan Sadhasivam To: Mayank Rana Cc: jingoohan1@gmail.com, will@kernel.org, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, krzk@kernel.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_krichai@quicinc.com Subject: Re: [PATCH v3 0/4] Add Qualcomm SA8255p based firmware managed PCIe root complex Message-ID: <20241119171037.53zxi47u643zztvx@thinkpad> References: <20241106221341.2218416-1-quic_mrana@quicinc.com> <20241115112802.66xoxj4z5wsg4idl@thinkpad> <6e9db73e-0441-453c-978c-961f308f8a11@quicinc.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6e9db73e-0441-453c-978c-961f308f8a11@quicinc.com> On Fri, Nov 15, 2024 at 10:31:17AM -0800, Mayank Rana wrote: > > > On 11/15/2024 3:28 AM, Manivannan Sadhasivam wrote: > > On Wed, Nov 06, 2024 at 02:13:37PM -0800, Mayank Rana wrote: > > > Based on received feedback, this patch series adds support with existing > > > Linux qcom-pcie.c driver to get PCIe host root complex functionality on > > > Qualcomm SA8255P auto platform. > > > > > > 1. Interface to allow requesting firmware to manage system resources and > > > performing PCIe Link up (devicetree binding in terms of power domain and > > > runtime PM APIs is used in driver) > > > > > > 2. SA8255P is using Synopsys Designware PCIe controller which supports MSI > > > controller. Using existing MSI controller based functionality by exporting > > > important pcie dwc core driver based MSI APIs, and using those from > > > pcie-qcom.c driver. > > > > > > Below architecture is used on Qualcomm SA8255P auto platform to get ECAM > > > compliant PCIe controller based functionality. Here firmware VM based PCIe > > > driver takes care of resource management and performing PCIe link related > > > handling (D0 and D3cold). Linux pcie-qcom.c driver uses power domain to > > > request firmware VM to perform these operations using SCMI interface. > > > -------------------- > > > > > > > > > ┌────────────────────────┐ > > > │ │ > > > ┌──────────────────────┐ │ SHARED MEMORY │ ┌──────────────────────────┐ > > > │ Firmware VM │ │ │ │ Linux VM │ > > > │ ┌─────────┐ │ │ │ │ ┌────────────────┐ │ > > > │ │ Drivers │ ┌──────┐ │ │ │ │ │ PCIE Qcom │ │ > > > │ │ PCIE PHY◄─┤ │ │ │ ┌────────────────┐ │ │ │ driver │ │ > > > │ │ │ │ SCMI │ │ │ │ │ │ │ │ │ │ > > > │ │PCIE CTL │ │ │ ├─────────┼───► PCIE ◄───┼─────┐ │ └──┬──────────▲──┘ │ > > > │ │ ├─►Server│ │ │ │ SHMEM │ │ │ │ │ │ │ > > > │ │Clk, Vreg│ │ │ │ │ │ │ │ │ │ ┌──▼──────────┴──┐ │ > > > │ │GPIO,GDSC│ └─▲──┬─┘ │ │ └────────────────┘ │ └──────┼────┤PCIE SCMI Inst │ │ > > > │ └─────────┘ │ │ │ │ │ │ └──▲──────────┬──┘ │ > > > │ │ │ │ │ │ │ │ │ │ > > > └───────────────┼──┼───┘ │ │ └───────┼──────────┼───────┘ > > > │ │ │ │ │ │ > > > │ │ └────────────────────────┘ │ │ > > > │ │ │ │ > > > │ │ │ │ > > > │ │ │ │ > > > │ │ │IRQ │HVC > > > IRQ │ │HVC │ │ > > > │ │ │ │ > > > │ │ │ │ > > > │ │ │ │ > > > ┌─────────────────┴──▼───────────────────────────────────────────────────────────┴──────────▼──────────────┐ > > > │ │ > > > │ │ > > > │ HYPERVISOR │ > > > │ │ > > > │ │ > > > │ │ > > > └──────────────────────────────────────────────────────────────────────────────────────────────────────────┘ > > > ┌─────────────┐ ┌─────────────┐ ┌──────────┐ ┌───────────┐ ┌─────────────┐ ┌────────────┐ > > > │ │ │ │ │ │ │ │ │ PCIE │ │ PCIE │ > > > │ CLOCK │ │ REGULATOR │ │ GPIO │ │ GDSC │ │ PHY │ │ controller │ > > > └─────────────┘ └─────────────┘ └──────────┘ └───────────┘ └─────────────┘ └────────────┘ > > > > Thanks a lot for working on this Mayank! This version looks good to me. I've > > left some comments, nothing alarming though. > Thanks for reviewing change. I would address those in next patchset. > > > But I do want to hold up this series until we finalize the SCMI based design. > ok. I want to send these changes which are prepared based on previously > provided feedback, to see if we have any major concern here in terms of > getting functionality. > That's fine. My comment was a note to the maintainers. - Mani -- மணிவண்ணன் சதாசிவம்